compat: use STDIN_FILENO over 0 #26809

1. 
   fanquake commented at 12:11 pm on January 4, 2023: member

   This is already used throughout this file, and is self-documenting.
2. compat: use STDIN_FILENO over 0

   This is already used throughout this file, and is self-documenting.

   585c672212
3. 
   DrahtBot commented at 12:11 pm on January 4, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto, kristapsk, aureleoules, john-moffett, achow101
   Concept ACK	murrayn

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Utils/log/libs on Jan 4, 2023
5. hebasto approved
6. 
   hebasto commented at 12:14 pm on January 4, 2023: member

   ACK 585c6722128537f772043ef4c87238e283669b8a, I have reviewed the code and it looks OK, I agree it can be merged.
7. maflcko added the label DrahtBot Guix build requested on Jan 4, 2023
8. 
   kristapsk commented at 12:33 pm on January 4, 2023: contributor

   I don’t think this is compatible with Windows. STDIN_FILENO is defined in unistd.h. MSDN suggests to use _fileno(stdin) for Windows instead.
9. 
   murrayn commented at 12:33 pm on January 4, 2023: contributor

   ACK 585c672, my initial concern was with WIN32, but the code block is explicitly not WIN32.
10. 
    fanquake commented at 12:33 pm on January 4, 2023: member

    I don’t think this is compatible with Windows.

    The code is in a non-windows block.

11. 
    kristapsk commented at 12:34 pm on January 4, 2023: contributor

    I don’t think this is compatible with Windows.

    The code is in a non-windows block.

    Yes, sorry, missed that.

12. kristapsk approved
13. 
    kristapsk commented at 12:34 pm on January 4, 2023: contributor

    utACK 585c6722128537f772043ef4c87238e283669b8a
14. aureleoules approved
15. 
    aureleoules commented at 12:53 pm on January 4, 2023: member

    ACK 585c6722128537f772043ef4c87238e283669b8a
16. 
    john-moffett commented at 1:43 pm on January 4, 2023: contributor

    ACK 585c6722128537f772043ef4c87238e283669b8a
17. 
    DrahtBot commented at 10:19 pm on January 4, 2023: contributor

    Guix builds

    File	commit bf3b589413568b12b130af66e134f6670d3026ac(master)	commit 735e49d498095f709b848cc496254951b5f3e619(master and this pull)
    SHA256SUMS.part	d4763a892d2b0032...	7ae2d9921086b743...
    *-aarch64-linux-gnu-debug.tar.gz	ec88fba0b85f9d24...	2fd6627fca85e1cb...
    *-aarch64-linux-gnu.tar.gz	ba8f072dbb18a009...	9758d6747c3964b6...
    *-arm-linux-gnueabihf-debug.tar.gz	a4a7cefe1891873b...	f5b959a98bf7e376...
    *-arm-linux-gnueabihf.tar.gz	8ffb7724b8f683af...	80be620436075063...
    *-arm64-apple-darwin-unsigned.dmg	9ea2800ddcc13347...	7553d5edb4e1db2a...
    *-arm64-apple-darwin-unsigned.tar.gz	e6b3bc378ac6ef33...	1b3a48cba7a536f6...
    *-arm64-apple-darwin.tar.gz	11100a0d6fdf8f79...	20ac741a6106b17d...
    *-powerpc64-linux-gnu-debug.tar.gz	e24e8c72d5fee875...	d924aec4715af1fe...
    *-powerpc64-linux-gnu.tar.gz	939b3b9989cd758e...	6298d849d86e925c...
    *-powerpc64le-linux-gnu-debug.tar.gz	981b5dce27dad9e0...	e9ea614a6b25c216...
    *-powerpc64le-linux-gnu.tar.gz	45efa7861dac8dc0...	d48e9168ccd487e2...
    *-riscv64-linux-gnu-debug.tar.gz	2d77ad3ada06373f...	3013993cd7440c96...
    *-riscv64-linux-gnu.tar.gz	1d2f1da771beeae3...	196f47fc9113bc4c...
    *-win64-debug.zip	8b03460b1b56cf35...	4145a60f0026fc3b...
    *-win64-setup-unsigned.exe	b1c510894e05120a...	5c654539c2d6df4b...
    *-win64-unsigned.tar.gz	87c134c0f4a497da...	db0f76803151faef...
    *-win64.zip	0a6d6dc9499b3b90...	7ab22539974d20ed...
    *-x86_64-apple-darwin-unsigned.dmg	5accc9b7a61701db...	028593b839139115...
    *-x86_64-apple-darwin-unsigned.tar.gz	337f48ec684ca772...	08b615a5adc1a4b0...
    *-x86_64-apple-darwin.tar.gz	52ae0c5145f777ef...	c8f8f2189f4eb35c...
    *-x86_64-linux-gnu-debug.tar.gz	2676d8bfdafab0ec...	d6b54a30f41f426f...
    *-x86_64-linux-gnu.tar.gz	de1f8b5be2cac1d9...	89138ef36fd6ff4b...
    *.tar.gz	71471f54d8359028...	b7fbec0466aef16f...
    guix_build.log	24bdca0985f418cc...	6f39fbab3931a07d...
    guix_build.log.diff		c1299188b92d045f...

18. DrahtBot removed the label DrahtBot Guix build requested on Jan 4, 2023
19. 
    achow101 commented at 10:25 pm on January 4, 2023: member

    ACK 585c6722128537f772043ef4c87238e283669b8a
20. achow101 referenced this in commit cabeae43ea on Jan 4, 2023
21. 
    achow101 commented at 10:40 pm on January 4, 2023: member

    This was merged
22. achow101 closed this on Jan 4, 2023

    ---

23. fanquake deleted the branch on Jan 5, 2023
24. sidhujag referenced this in commit 7ef4e3c03e on Jan 5, 2023
25. bitcoin locked this on Jan 5, 2024

Contributors
fanquake DrahtBot hebasto kristapsk murrayn aureleoules john-moffett achow101

Labels
Utils/log/libs