compat: use STDIN_FILENO over 0 #26809
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:compat_STDIN_FILENO changing 1 files +1 −1-
fanquake commented at 12:11 pm on January 4, 2023: memberThis is already used throughout this file, and is self-documenting.
-
compat: use STDIN_FILENO over 0
This is already used throughout this file, and is self-documenting.
-
DrahtBot commented at 12:11 pm on January 4, 2023: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK hebasto, kristapsk, aureleoules, john-moffett, achow101 Concept ACK murrayn If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
DrahtBot added the label Utils/log/libs on Jan 4, 2023
-
hebasto approved
-
hebasto commented at 12:14 pm on January 4, 2023: memberACK 585c6722128537f772043ef4c87238e283669b8a, I have reviewed the code and it looks OK, I agree it can be merged.
-
maflcko added the label DrahtBot Guix build requested on Jan 4, 2023
-
murrayn commented at 12:33 pm on January 4, 2023: contributorACK 585c672, my initial concern was with WIN32, but the code block is explicitly not WIN32.
-
fanquake commented at 12:33 pm on January 4, 2023: member
I don’t think this is compatible with Windows.
The code is in a non-windows block.
-
kristapsk commented at 12:34 pm on January 4, 2023: contributor
I don’t think this is compatible with Windows.
The code is in a non-windows block.
Yes, sorry, missed that.
-
kristapsk approved
-
kristapsk commented at 12:34 pm on January 4, 2023: contributorutACK 585c6722128537f772043ef4c87238e283669b8a
-
aureleoules approved
-
aureleoules commented at 12:53 pm on January 4, 2023: memberACK 585c6722128537f772043ef4c87238e283669b8a
-
john-moffett commented at 1:43 pm on January 4, 2023: contributorACK 585c6722128537f772043ef4c87238e283669b8a
-
DrahtBot commented at 10:19 pm on January 4, 2023: contributor
Guix builds
-
DrahtBot removed the label DrahtBot Guix build requested on Jan 4, 2023
-
achow101 commented at 10:25 pm on January 4, 2023: memberACK 585c6722128537f772043ef4c87238e283669b8a
-
achow101 referenced this in commit cabeae43ea on Jan 4, 2023
-
achow101 commented at 10:40 pm on January 4, 2023: memberThis was merged
-
achow101 closed this on Jan 4, 2023
-
fanquake deleted the branch on Jan 5, 2023
-
sidhujag referenced this in commit 7ef4e3c03e on Jan 5, 2023
-
bitcoin locked this on Jan 5, 2024
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-31 03:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-31 03:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me