refactor: Make `ThreadHTTP` return void #26821

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:220105-http changing 1 files +1 −2
  1. hebasto commented at 5:55 PM on January 5, 2023: member

    The bool return value was introduced in 755aa05174e06effd758eeb78c5af9fb465e9611 (https://github.com/bitcoin/bitcoin/pull/8421).

    It has been not used since 8d3f46ec3938e2ba17654fecacd1d2629f9915fd (https://github.com/bitcoin/bitcoin/pull/14670).

    No behavior change.

  2. refactor: Make `ThreadHTTP` return void
    The `bool` return value was introduced in 755aa05174e06effd758eeb78c5af9fb465e9611.
    
    It has been not used since 8d3f46ec3938e2ba17654fecacd1d2629f9915fd.
    
    No behavior change.
    45553e11c9
  3. DrahtBot commented at 5:55 PM on January 5, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK brunoerg, w0xlt, stickies-v, achow101

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Refactoring on Jan 5, 2023
  5. brunoerg approved
  6. brunoerg commented at 6:03 PM on January 5, 2023: contributor

    crACK 45553e11c965db218733f9ad32ecde391b393443

  7. w0xlt approved
  8. fanquake requested review from stickies-v on Jan 11, 2023
  9. stickies-v approved
  10. stickies-v commented at 6:20 PM on January 11, 2023: contributor

    ACK 45553e11c

    I was wondering recently why we had this line. Bye!

  11. achow101 commented at 9:38 PM on January 11, 2023: member

    ACK 45553e11c965db218733f9ad32ecde391b393443

  12. achow101 merged this on Jan 11, 2023
  13. achow101 closed this on Jan 11, 2023

  14. hebasto deleted the branch on Jan 12, 2023
  15. sidhujag referenced this in commit 9f7234b5a0 on Jan 12, 2023
  16. bitcoin locked this on Jan 12, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me