compat: move (win) S_* defines into bdb #26832

1. 
   fanquake commented at 9:08 am on January 6, 2023: member

   This is the only place these defines are used. They may also be available when building for Windows. sys/stat.h is available, and we already use it unguarded in other code. So move the defines into bdb, after the stat.h include, and remove compat from bdb.cpp.
2. 
   DrahtBot commented at 9:08 am on January 6, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto, TheCharlatan

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   No conflicts as of last run.

3. DrahtBot added the label Utils/log/libs on Jan 6, 2023
4. 
   hebasto commented at 9:32 am on January 6, 2023: member

   Concept ACK.
5. fanquake force-pushed on Feb 14, 2023
6. 
   fanquake commented at 3:29 pm on February 14, 2023: member

   Rebased on #27098.
7. fanquake marked this as ready for review on Feb 17, 2023
8. fanquake force-pushed on Feb 17, 2023
9. 
   TheCharlatan commented at 4:46 pm on February 20, 2023: contributor

   I feel like I’m missing some context here. Why move these out of compat? There are also other symbols like WSAEAGAIN that are only used in one other file.
10. 
    fanquake commented at 3:02 pm on March 23, 2023: member

    I feel like I’m missing some context here. Why move these out of compat?

    My plan was to split compat up further, so we didn’t have the singular compat.h, with everything thrown in.

11. 
    TheCharlatan commented at 3:29 pm on March 23, 2023: contributor

    Light code review ACK cf0d86ed15041822e2a0a55ddf231af7809a9e66
12. refactor: don't avoid sys/types.h on when building for Windows

    We've already used it unguarded in `httpserver.cpp` for years, with no
    build issues.

    54e4061189
13. fanquake force-pushed on Apr 3, 2023
14. 
    fanquake commented at 1:46 pm on April 3, 2023: member

    Rebased for #27254.
15. hebasto approved
16. 
    hebasto commented at 7:08 pm on April 4, 2023: member

    ACK 54e406118926c2a526455a60f67961520dfb65da, I have reviewed the code and it looks OK.

    nit: Two commits “refactor: don’t avoid sys/types.h on when building for Windows” and “compat: move (win) S_* defines into bdb” were squashed but the commit message of the latter was lost.

17. DrahtBot requested review from TheCharlatan on Apr 4, 2023
18. 
    TheCharlatan commented at 8:45 pm on April 4, 2023: contributor

    re-ACK 54e406118926c2a526455a60f67961520dfb65da
19. DrahtBot removed review request from TheCharlatan on Apr 4, 2023
20. fanquake merged this on Apr 5, 2023
21. fanquake closed this on Apr 5, 2023

    ---

22. fanquake deleted the branch on Apr 5, 2023
23. sidhujag referenced this in commit fd5d560e85 on Apr 5, 2023
24. bitcoin locked this on Apr 4, 2024

Contributors
fanquake DrahtBot hebasto TheCharlatan

Labels
Utils/log/libs