sys/stat.h
is available, and we already use it unguarded in other code. So move the defines into bdb, after the stat.h include, and remove compat from bdb.cpp.
compat: move (win) S_* defines into bdb #26832
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:dont_exclude_stat_win_bdb changing 4 files +13 −12-
fanquake commented at 9:08 am on January 6, 2023: memberThis is the only place these defines are used. They may also be available when building for Windows.
-
DrahtBot commented at 9:08 am on January 6, 2023: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK hebasto, TheCharlatan If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Conflicts
No conflicts as of last run.
-
DrahtBot added the label Utils/log/libs on Jan 6, 2023
-
hebasto commented at 9:32 am on January 6, 2023: memberConcept ACK.
-
fanquake force-pushed on Feb 14, 2023
-
fanquake marked this as ready for review on Feb 17, 2023
-
fanquake force-pushed on Feb 17, 2023
-
TheCharlatan commented at 4:46 pm on February 20, 2023: contributorI feel like I’m missing some context here. Why move these out of compat? There are also other symbols like
WSAEAGAIN
that are only used in one other file. -
fanquake commented at 3:02 pm on March 23, 2023: member
I feel like I’m missing some context here. Why move these out of compat?
My plan was to split compat up further, so we didn’t have the singular compat.h, with everything thrown in.
-
TheCharlatan commented at 3:29 pm on March 23, 2023: contributorLight code review ACK cf0d86ed15041822e2a0a55ddf231af7809a9e66
-
refactor: don't avoid sys/types.h on when building for Windows
We've already used it unguarded in `httpserver.cpp` for years, with no build issues.
-
fanquake force-pushed on Apr 3, 2023
-
hebasto approved
-
hebasto commented at 7:08 pm on April 4, 2023: member
ACK 54e406118926c2a526455a60f67961520dfb65da, I have reviewed the code and it looks OK.
nit: Two commits “refactor: don’t avoid sys/types.h on when building for Windows” and “compat: move (win) S_* defines into bdb” were squashed but the commit message of the latter was lost.
-
DrahtBot requested review from TheCharlatan on Apr 4, 2023
-
TheCharlatan commented at 8:45 pm on April 4, 2023: contributorre-ACK 54e406118926c2a526455a60f67961520dfb65da
-
DrahtBot removed review request from TheCharlatan on Apr 4, 2023
-
fanquake merged this on Apr 5, 2023
-
fanquake closed this on Apr 5, 2023
-
fanquake deleted the branch on Apr 5, 2023
-
sidhujag referenced this in commit fd5d560e85 on Apr 5, 2023
-
bitcoin locked this on Apr 4, 2024
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-31 03:12 UTC
More mirrored repositories can be found on mirror.b10c.me