ci: remove ccache version pin in MSVC CI #26866

1. 
   fanquake commented at 4:18 pm on January 10, 2023: member

   The pinning should no-longer be needed; 4.6.2 was broken, latest is 4.7.4, and that includes the necessary fixes.
2. 
   DrahtBot commented at 4:18 pm on January 10, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Concept NACK	MarcoFalke

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Tests on Jan 10, 2023
4. 
   fanquake commented at 4:23 pm on January 10, 2023: member

   Guess this might just be an intermitent Chocolatey issue?:

   0C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build>call choco install --yes --no-progress ccache 
   1Chocolatey v1.1.0
   2Installing the following packages:
   3ccache
   4By installing, you accept licenses for the packages.
   5ccache not installed. The package was not found with the source(s) listed.
   6 Source(s): 'https://community.chocolatey.org/api/v2/'
   7 NOTE: When you specify explicit sources, it overrides default sources.
   

5. ci: remove ccache version pin in MSVC CI

   The pinning should no-longer be needed; 4.6.2 was broken, latest is
   4.7.4, and that includes the necessary fixes.

   b39f79b128
6. fanquake force-pushed on Jan 11, 2023
7. 
   fanquake commented at 10:40 am on January 11, 2023: member

   Chocolately seems to have fixed itself, so I’ve changed the wording here to just drop the ccache version pin, as it’s no-longer necessary, and I don’t think we’ve got a reason to remain pinned.
8. 
   maflcko commented at 11:01 am on January 11, 2023: member

   NACK. The reason is that a broken version will break our CI and we’ll have to pin it to fix the problem. Everything else is pinned, so why should this not be pinned?
9. 
   fanquake commented at 11:12 am on January 11, 2023: member

   Everything else is pinned, so why should this not be pinned?

   In this case I don’t care too much either way, but I think if we are going to have things pinned, (in general) we could document why. This was pinned because of a bug that has since been fixed, and staying pinned is at best, worse than using the latest working version (i.e pinning to 4.6.x is just missing multiple performance improvements / bug fixes over 4.7.x). I guess the better change here is too just change the pin to 4.7.4, but feel free to close.

10. fanquake closed this on Jan 11, 2023

    ---

11. fanquake deleted the branch on Jan 11, 2023
12. 
    maflcko commented at 11:19 am on January 11, 2023: member

    No objection to bumping it or adding documentation.

    ccache (for windows) isn’t really used, looking at the download numbers, https://community.chocolatey.org/packages/ccache#versionhistory, so I’d prefer if someone else is doing the nightly testing outside of our production CI

13. maflcko referenced this in commit 08d2a3ab4b on Jan 16, 2023
14. bitcoin locked this on Jan 11, 2024

Contributors
fanquake DrahtBot maflcko

Labels
Tests