doc: Mention restoring wallet via GUI #26867

pull john-moffett wants to merge 2 commits into bitcoin:master from john-moffett:2023_01_DocWalletRestoreGUI changing 1 files +4 −4
  1. john-moffett commented at 8:27 PM on January 10, 2023: contributor

    https://github.com/bitcoin/bitcoin/commit/f9783b0f07c0c9a5dd55e1779ece5ab66519c2f2 Recently added the ability to restore wallets via the GUI, but the current wallet guide says backups must be restored via RPC.

  2. DrahtBot commented at 8:27 PM on January 10, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto, kouloumos, jarolrod

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Docs on Jan 10, 2023
  4. fanquake requested review from hebasto on Jan 11, 2023
  5. fanquake requested review from jarolrod on Jan 11, 2023
  6. in doc/managing-wallets.md:115 in 46687594b3 outdated 
     107 | @@ -108,7 +108,11 @@ Wallets created before version 0.13 are not HD and must be backed up every 100 k
 108 |  
 109 |  ### 1.6 Restoring the Wallet From a Backup
 110 |  
 111 | -To restore a wallet, the `restorewallet` RPC must be used.
 112 | +To restore a wallet, the `restorewallet` RPC or the `Restore Wallet` GUI menu item must be used.
 113 | +
 114 | +In the GUI, a backup can be restored via `File` -> `Restore Wallet...`.
 115 | +
 116 | +Alternatively, a backup can be restored using the `restorewallet` RPC.
    jarolrod commented at 6:58 AM on January 12, 2023:

    nit would be to remove this line, it's already mentioned that restorewallet is an rpc command on line 111. Semantics, but i would say the GUI method is an alternative to the RPC method

    kouloumos commented at 7:41 AM on January 12, 2023:

    I agree with this. I believe that the reason that it is repeated here is because it needs to refer to the RPC before the command in the line below. An alternative could be to follow the same approach as the "1.4 Backing Up the Wallet" section and give a bit more direction/information on the arguments of the RPC commands. But removing it also makes sense, if the above GUI reference is moved.

  7. jarolrod commented at 7:19 AM on January 12, 2023: member

    Concept ACK

    I think we can further simplify this section as so:

    @@ -110,10 +110,6 @@ Wallets created before version 0.13 are not HD and must be backed up every 100 k

 To restore a wallet, the `restorewallet` RPC or the `Restore Wallet` GUI menu item must be used.

-In the GUI, a backup can be restored via `File` -> `Restore Wallet...`.
-
-Alternatively, a backup can be restored using the `restorewallet` RPC.
@@ -124,6 +120,7 @@ After that, `getwalletinfo` can be used to check if the wallet has been fully re

+In the GUI, a backup can be restored via `File` -> `Restore Wallet`.
 The restored wallet can also be loaded in the GUI via `File` ->`Open wallet`.
  8. in doc/managing-wallets.md:148 in 46687594b3 outdated 
     147 | @@ -144,5 +148,5 @@ unforeseen configurations which result in some scripts being excluded. If a migr
 148 |  unexpectedly or otherwise misses any scripts, please create an issue on GitHub. A backup of the
 149 |  original wallet can be found in the wallet directory with the name `<name>-<timestamp>.legacy.bak`.
 150 |  
 151 | -The backup can be restored using the `restorewallet` command as discussed in the
 152 | -[Restoring the Wallet From a Backup](#16-restoring-the-wallet-from-a-backup) section
 153 | +The backup can be restored using the `restorewallet` command or the `Restore Wallet` GUI menu item as discussed in the
 154 | +[Restoring the Wallet From a Backup](#16-restoring-the-wallet-from-a-backup) section.
    kouloumos commented at 7:29 AM on January 12, 2023:

    As this is now discussing more than one methods, maybe it can become more future-proof by not specifying the methods here?

    The backup can be restored using the methods discussed in the
[Restoring the Wallet From a Backup](#16-restoring-the-wallet-from-a-backup) section.
  9. in doc/managing-wallets.md:113 in 46687594b3 outdated 
     107 | @@ -108,7 +108,11 @@ Wallets created before version 0.13 are not HD and must be backed up every 100 k
 108 |  
 109 |  ### 1.6 Restoring the Wallet From a Backup
 110 |  
 111 | -To restore a wallet, the `restorewallet` RPC must be used.
 112 | +To restore a wallet, the `restorewallet` RPC or the `Restore Wallet` GUI menu item must be used.
 113 | +
 114 | +In the GUI, a backup can be restored via `File` -> `Restore Wallet...`.
    kouloumos commented at 7:34 AM on January 12, 2023:

    Following the format of the "1.4 Backing Up the Wallet" section, I believe this is better to go bellow the RPC command https://github.com/bitcoin/bitcoin/blob/fbe5e1220a35c35a668ec965c66508a7839aa7dd/doc/managing-wallets.md?plain=1#L114

  10. kouloumos commented at 7:43 AM on January 12, 2023: contributor

    Concept ACK

  11. john-moffett force-pushed on Jan 12, 2023
  12. john-moffett commented at 2:35 PM on January 12, 2023: contributor

    Thank you for the comments, @jarolrod and @kouloumos. I updated it and tried to keep it simpler. Since the GUI method requires no significant explanation, I tried to just "inline" it rather than split up the two methods and give detailed explanations for each.

    I like the future-proofing suggestion, @kouloumos.

  13. in doc/managing-wallets.md:111 in 118ec94d70 outdated 
     107 | @@ -108,7 +108,7 @@ Wallets created before version 0.13 are not HD and must be backed up every 100 k
 108 |  
 109 |  ### 1.6 Restoring the Wallet From a Backup
 110 |  
 111 | -To restore a wallet, the `restorewallet` RPC must be used.
 112 | +To restore a wallet, the `restorewallet` RPC or the `Restore Wallet` GUI menu item (`File` -> `Restore Wallet...`) must be used.
    hebasto commented at 3:35 PM on January 12, 2023:

    nit: Actually, the symbol is ellipsis:

    To restore a wallet, the `restorewallet` RPC or the `Restore Wallet` GUI menu item (`File` -> `Restore Wallet…`) must be used.

    See https://github.com/bitcoin/bitcoin/blob/edc3d1b296e34838d649dc21b8483a52e214932a/src/qt/bitcoingui.cpp#L353

    john-moffett commented at 3:51 PM on January 12, 2023:

    Thanks, @hebasto. I'll change the "..." usage to "…" at the end of line 91 as well.

    https://github.com/bitcoin/bitcoin/blob/118ec94d70b293b95aa9d2713733c8e1d9b63b92/doc/managing-wallets.md?plain=1#L91

  14. hebasto approved
  15. hebasto commented at 3:35 PM on January 12, 2023: member

    ACK 118ec94d70b293b95aa9d2713733c8e1d9b63b92, doc update is correct. Being a non-native English speaker, I cannot make full assessment about style and grammar, but they look good.

  16. john-moffett force-pushed on Jan 12, 2023
  17. in doc/managing-wallets.md:91 in 61b5291b7a outdated 
      87 | @@ -88,7 +88,7 @@ In the RPC, the destination parameter must include the name of the file. Otherwi
  88 |  $ bitcoin-cli -rpcwallet="wallet-01" backupwallet /home/node01/Backups/backup-01.dat
  89 |  ```
  90 |  
  91 | -In the GUI, the wallet is selected in the `Wallet` drop-down list in the upper right corner. If this list is not present, the wallet can be loaded in `File` ->`Open wallet` if necessary. Then, the backup can be done in `File` -> `Backup Wallet...`.
  92 | +In the GUI, the wallet is selected in the `Wallet` drop-down list in the upper right corner. If this list is not present, the wallet can be loaded in `File` ->`Open wallet` if necessary. Then, the backup can be done in `File` -> `Backup Wallet…`.
    hebasto commented at 4:08 PM on January 12, 2023:

    Considering the commit message, this change looks unrelated. Maybe drop it or move into another commit. If the latter will be chosen

    In the GUI, the wallet is selected in the `Wallet` drop-down list in the upper right corner. If this list is not present, the wallet can be loaded in `File` ->`Open Wallet` if necessary. Then, the backup can be done in `File` -> `Backup Wallet…`.
  18. hebasto approved
  19. hebasto commented at 4:08 PM on January 12, 2023: member

    re-ACK 61b5291b7a03e0221e0f9abaff39f9de166e25d0

  20. Update to mention restoring wallet via GUI 9b158ae73f
  21. Change dots to an ellipsis and fix capitalization
    Matches ellipsis usage in the "Restore" section.
    dc9bad5192
  22. john-moffett force-pushed on Jan 12, 2023
  23. hebasto approved
  24. hebasto commented at 4:34 PM on January 12, 2023: member

    re-ACK dc9bad5192991219ab71c9046e197e2f18791d9e

  25. kouloumos commented at 4:40 PM on January 12, 2023: contributor

    ACK dc9bad5192991219ab71c9046e197e2f18791d9e I would be ok even with the changes in a single commit.

  26. jarolrod commented at 4:26 AM on January 13, 2023: member

    re-ACK dc9bad5

  27. maflcko merged this on Jan 13, 2023
  28. maflcko closed this on Jan 13, 2023
  29. sidhujag referenced this in commit 0b801ca96a on Jan 13, 2023
  30. bitcoin locked this on Jan 13, 2024
Contributors
john-moffettDrahtBotjarolrodkouloumoshebasto
Labels
Docs
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 00:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me