doc: add databases/py-sqlite3 to FreeBSD test suite deps #26873

1. 
   fanquake commented at 5:36 pm on January 11, 2023: member

   Adds missing documentation. See also https://cirrus-ci.com/task/5639240319500288.
2. doc: add databases/py-sqlite3 to FreeBSD test suite deps 376e01b382
3. fanquake added the label Docs on Jan 11, 2023
4. 
   DrahtBot commented at 5:37 pm on January 11, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	john-moffett

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. 
   fanquake commented at 10:58 am on January 12, 2023: member

   cc @murrayn
6. 
   murrayn commented at 12:20 pm on January 12, 2023: contributor

   There seems to be some other issue in that this test should not be getting run if any of its dependencies are not available.
7. 
   maflcko commented at 12:23 pm on January 12, 2023: member

   Personally I am fine to just require the dependency
8. 
   fanquake commented at 12:24 pm on January 12, 2023: member

   Yea. I don’t see the issue here. SQLite is available. Seems FreeBSD just needs another package to expose it to Python.
9. 
   murrayn commented at 12:46 pm on January 12, 2023: contributor

   I would rather not make another special documentation case for FreeBSD before we can rule out a code issue. On Linux, the test is skipped if the dependency is not there.
10. 
    maflcko commented at 12:49 pm on January 12, 2023: member

    I think the test is only skipped if sqlite was not compiled into bitcoind? Which (in theory) is different from py-sqlite3 being installed, at least on FreeBSD.
11. 
    fanquake commented at 1:13 pm on January 12, 2023: member

    Yep. Adding this to the documentation is no different to having to pip install pyzmq or apt install python3-zmq to run the zeromq related functional tests.
12. 
    maflcko commented at 1:18 pm on January 12, 2023: member

    In theory it would be possible to write a skip function if py-sqlite3 is not there, based on import sqlite3 and

    https://github.com/bitcoin/bitcoin/blob/edc3d1b296e34838d649dc21b8483a52e214932a/test/functional/test_framework/test_framework.py#L850-L855

13. fanquake referenced this in commit 2deb6ac321 on Jan 12, 2023
14. fanquake referenced this in commit eea73d465e on Jan 12, 2023
15. maflcko referenced this in commit 32834034a3 on Jan 13, 2023
16. 
    fanquake commented at 12:56 pm on January 13, 2023: member

    The tests have now been fixed in any case, so this is just adding the missing the documentation.
17. 
    fanquake commented at 12:22 pm on January 18, 2023: member

    @john-moffett want to review?
18. 
    john-moffett commented at 1:58 pm on January 18, 2023: contributor

    ACK 376e01b382679b49d5c8464c869d14eca23ab4b9

    The sqlite3 module is already included in most other python package distributions since it’s part of the standard library, so FreeBSD seems like an outlier in that respect. It’s a very small dependency and tests an important piece of wallet functionality, so it makes sense to specifically include it here.

19. fanquake merged this on Jan 18, 2023
20. fanquake closed this on Jan 18, 2023

    ---

21. fanquake deleted the branch on Jan 18, 2023
22. sidhujag referenced this in commit 339dab7655 on Jan 19, 2023
23. aguycalled referenced this in commit 1184856133 on Jan 27, 2023
24. bitcoin locked this on Jan 18, 2024

Contributors
fanquake DrahtBot murrayn maflcko john-moffett

Labels
Docs