Clean up mining CReserveKey to prevent crash at shutdown #2688

pull gavinandresen wants to merge 1 commits into bitcoin:master from gavinandresen:issue2687 changing 3 files +14 −6
  1. gavinandresen commented at 6:18 PM on May 23, 2013: contributor

    This is better memory management of the mining CReserveKey, anyway.

    Fixes issue#2687

  2. Clean up mining CReserveKey to prevent crash at shutdown
    Fixes issue#2687
    36e826cea1
  3. gmaxwell commented at 6:39 PM on May 23, 2013: contributor

    Fixes #2687

  4. BitcoinPullTester commented at 7:12 PM on May 23, 2013: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/36e826cea14585f68d5c363a82c1a887a779e130 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  5. wtogami commented at 8:51 AM on May 24, 2013: contributor

    I am seeing a different assertion failure during bitcoind "stop" both before and after this patch.

    /usr/include/boost/thread/pthread/recursive_mutex.hpp:105: void boost::recursive_mutex::lock(): Assertion `!pthread_mutex_lock(&m)' failed.

    I am able to reproduce this easily with my native build on Fedora 18 x86_64 with boost-1.50.0-5.fc18.x86_64, but after 20 attempts it didn't seem to happen with the gitian build.

    Should I open a new issue?

  6. gavinandresen referenced this in commit 1472a2991b on May 24, 2013
  7. gavinandresen merged this on May 24, 2013
  8. gavinandresen closed this on May 24, 2013

  9. gavinandresen deleted the branch on Nov 4, 2013
  10. laudney referenced this in commit 9da622cf6f on Mar 19, 2014
  11. DrahtBot locked this on Sep 8, 2021

Milestone
v0.8.2


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 15:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me