This PR adds missing test coverage for the -spendzeroconfchange setting (in particular the non-default case =0). Note that in contrast to the name, the setting does not only apply to change outputs, but in fact to all unconfirmed outputs that we sent to ourselves, i.e. we can trigger the testing path simply with a single recipient address. The first commit removes the setting from the functional test mempool_limit.py, where it doesn't have any effect, since the test was changed to use MiniWallet in commit dddca3899c4738e512313a85aeb006310e34e31f.
test: wallet: add coverage for `-spendzeroconfchange` setting #26884
pull theStack wants to merge 2 commits into bitcoin:master from theStack:202301-test-add_nospendzeroconfchange_coverage changing 2 files +39 −1-
theStack commented at 3:13 AM on January 13, 2023: contributor
-
50112034bc
test: remove `-spendzeroconfchange` setting from mempool_limit.py
Since this test was changed to use MiniWallet instead of the Bitcoin Core wallet (see commit d447ded6babebe7c7948e585c9e78bf34dbef226), the setting doesn't have any effect and hence can be removed.
-
DrahtBot commented at 3:13 AM on January 13, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK brunoerg If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Jan 13, 2023
-
brunoerg commented at 2:51 PM on January 13, 2023: contributor
Concept ACK
-
brunoerg commented at 2:58 PM on January 13, 2023: contributor
I think we could also test the behavior of
getbalancewithspendzeroconfchange. -
test: wallet: add coverage for `-spendzeroconfchange` setting 603d295199
- theStack force-pushed on Jan 13, 2023
-
theStack commented at 8:59 PM on January 13, 2023: contributor
I think we could also test the behavior of
getbalancewithspendzeroconfchange.Good idea, done. Used
getbalancesrather thangetbalanceto check in which category unconfirmed self-sent coins fall (trusted or untrusted_pending) depending on the-spendzeroconfchangesetting. - brunoerg approved
-
brunoerg commented at 4:41 PM on January 16, 2023: contributor
crACK 603d29519931e6ab6a58db09b9d3eb9b355fe566
Nice!
- maflcko merged this on Jan 17, 2023
- maflcko closed this on Jan 17, 2023
- theStack deleted the branch on Jan 17, 2023
- sidhujag referenced this in commit 6782c9b317 on Jan 17, 2023
- bitcoin locked this on Jan 17, 2024
