net: simplify the call to vProcessMsg.splice() #26888

pull vasild wants to merge 1 commits into bitcoin:master from vasild:simplify_vProcessMsg_splice changing 2 files +6 −8

vasild commented at 1:52 PM on January 13, 2023: contributor
At the time when
```
pnode->vProcessMsg.splice(pnode->vProcessMsg.end(), pnode->vRecvMsg, pnode->vRecvMsg.begin(), it);
```
is called, it is certainly pnode->vRecvMsg.end() which makes the call equivalent to:
```
pnode->vProcessMsg.splice(pnode->vProcessMsg.end(), pnode->vRecvMsg, pnode->vRecvMsg.begin(), pnode->vRecvMsg.end());
```
which is equivalent to:
```
pnode->vProcessMsg.splice(pnode->vProcessMsg.end(), pnode->vRecvMsg);
```
Thus, use the latter. Further, maybe irrelevant, but the latter has constant complexity while the original code is O(length of vRecvMsg).
DrahtBot commented at 1:52 PM on January 13, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK theStack, MarcoFalke, jonatack

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label P2P on Jan 13, 2023
theStack commented at 3:51 PM on January 21, 2023: contributor

Concept ACK

Could apply the same simplifcation to ConnmanTestMsg::NodeReceiveMsgBytes (in ./src/test/util/net.cpp)?

Type	Reviewers
ACK	theStack, MarcoFalke, jonatack

net: simplify the call to vProcessMsg.splice()

At the time when

```cpp
pnode->vProcessMsg.splice(pnode->vProcessMsg.end(), pnode->vRecvMsg, pnode->vRecvMsg.begin(), it);
```

is called, `it` is certainly `pnode->vRecvMsg.end()` which makes the
call equivalent to:

```cpp
pnode->vProcessMsg.splice(pnode->vProcessMsg.end(), pnode->vRecvMsg, pnode->vRecvMsg.begin(), pnode->vRecvMsg.end());
```

which is equivalent to:

```cpp
pnode->vProcessMsg.splice(pnode->vProcessMsg.end(), pnode->vRecvMsg);
```

Thus, use the latter. Further, maybe irrelevant, but the latter has
constant complexity while the original code is `O(length of vRecvMsg)`.

dfc01ccd73

vasild force-pushed on Jan 30, 2023
vasild commented at 10:22 AM on January 30, 2023: contributor

f58fe9cf9c...dfc01ccd73:

Could apply the same simplifcation to ConnmanTestMsg::NodeReceiveMsgBytes

Good catch, done!
theStack approved
theStack commented at 11:02 AM on January 30, 2023: contributor

Code-review ACK dfc01ccd73e1f12698278d467c241f398da9fc7d
maflcko commented at 4:09 PM on January 30, 2023: member

Looks like this was made superfluous in 6294ecdb8bb4eb7049a18c721ee8cb4a53d80a06
maflcko approved

maflcko commented at 4:22 PM on January 30, 2023: member

review ACK dfc01ccd73e1f12698278d467c241f398da9fc7d 🐑

<details><summary>Show signature</summary>

Signature:

</details>

jonatack commented at 4:22 PM on January 30, 2023: contributor

Light review ACK dfc01ccd73e1f12698278d467c241f398da9fc7d
maflcko merged this on Feb 1, 2023
maflcko closed this on Feb 1, 2023
sidhujag referenced this in commit 28d84f84bd on Feb 1, 2023
bitcoin locked this on Feb 1, 2024

Contributors

Labels

net: simplify the call to vProcessMsg.splice() #26888

Reviews