makefile.unix accidentally enables UPNP by default because =0 is defined #269

pull sneak wants to merge 1 commits into bitcoin:master from sneak:patch-1 changing 1 files +1 −1
  1. sneak commented at 1:40 AM on May 26, 2011: none

    The ifdef for USE_PNP below evals to "true" because it's defined to zero, thereby erroneously enabling UPNP even when it's initialized to zero, which is probably not what's desired. Commenting out the variable makes it not try to build UPNP support by default.

    make USE_PNP=1 reenables it nicely.

    (I assume the =0 was meant to default it to off?)

  2. The ifdef for USE_PNP below evals to "true" because it's defined to zero, thereby erroneously enabling UPNP even when it's initialized to zero, which is probably not what's desired. Commenting out the variable makes it not try to build UPNP support. bd3bd6a59a
  3. sipa commented at 10:23 AM on May 26, 2011: member

    No upnp built: USE_UPNP= upnp built but disabled by default: USE_UPNP=0 upnp built and enabled bt default: USE_UPNP=1

  4. TheBlueMatt commented at 10:24 AM on May 26, 2011: member

    Please read build-unix.txt, it explains this.

  5. sneak commented at 10:25 AM on May 26, 2011: none

    Is UPNP enabled the intended default behavior?

  6. TheBlueMatt commented at 10:27 AM on May 26, 2011: member

    Built in, but disabled by default ie USE_UPNP=0, which is the intended default.

  7. TheBlueMatt commented at 10:28 AM on May 26, 2011: member

    "USE_UPNP= no UPnP support, miniupnp not required; USE_UPNP=0 (the default) UPnP support turned off by default at runtime; USE_UPNP=1 UPnP support turned on by default at runtime." -from build-unix.txt

  8. sneak commented at 10:30 AM on May 26, 2011: none

    ahh, it's also the flag for the default runtime setting, didn't realize that.

  9. sneak closed this on May 26, 2011

  10. sipa referenced this in commit 0350c7e4b8 on Jul 28, 2015
  11. sipa referenced this in commit 7863d105ea on Aug 4, 2015
  12. sipa referenced this in commit 780d5b3c7b on Aug 23, 2015
  13. TheBlueMatt referenced this in commit a671356e1f on Oct 20, 2015
  14. sipa referenced this in commit 9177950c74 on Oct 21, 2015
  15. sipa referenced this in commit f4787d1caf on Oct 21, 2015
  16. sipa referenced this in commit 6557a8cd46 on Oct 26, 2015
  17. sipa referenced this in commit ea06490d14 on Oct 27, 2015
  18. dexX7 referenced this in commit 4b5799a20d on Nov 4, 2015
  19. sipa referenced this in commit 003bb87153 on Nov 5, 2015
  20. sipa referenced this in commit bfd83199c3 on Nov 11, 2015
  21. sipa referenced this in commit b437ea7ec9 on Nov 12, 2015
  22. sipa referenced this in commit 1d84107924 on Nov 12, 2015
  23. rebroad referenced this in commit 40ead34fbe on Dec 7, 2016
  24. CodeShark referenced this in commit e97cc126e2 on Jan 18, 2017
  25. deadalnix referenced this in commit 4c63780710 on Jan 19, 2017
  26. classesjack referenced this in commit 91734fd9c4 on Jan 2, 2018
  27. nining referenced this in commit 247c38dba0 on Jan 3, 2018
  28. attilaaf referenced this in commit 25d5b04f3b on Jan 13, 2020
  29. cryptapus referenced this in commit 3961b00136 on May 3, 2021
  30. laanwj referenced this in commit 39e306009b on May 11, 2021
  31. rajarshimaitra referenced this in commit d1ae621bb4 on Aug 5, 2021
  32. rajarshimaitra referenced this in commit 2a58ca2797 on Aug 5, 2021
  33. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 15:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me