ci: Add missing lint dependency (gpg) #26908

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2301-ci-lint-missing-🌌 changing 1 files +5 −1

maflcko commented at 6:07 PM on January 17, 2023: member
Also, document each dependency.

Adding gpg avoids errors when running a release or dev branch in the CI:

https://github.com/bitcoin/bitcoin/blob/01ec5308bf616740c804247043046b23b483df5c/ci/lint/06_script.sh#L30-L42
```
bash: line 1: gpg: command not found
```
https://cirrus-ci.com/task/4582854860996608?logs=lint#L185
DrahtBot commented at 6:07 PM on January 17, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Jan 17, 2023
ci: Add missing lint dependency fa87d71872

Type	Reviewers
ACK	hebasto

in ci/lint/04_install.sh:11 in f2037c6d5f outdated

   6 | @@ -7,7 +7,11 @@
   7 |  export LC_ALL=C
   8 |  
   9 |  ${CI_RETRY_EXE} apt-get update
  10 | -${CI_RETRY_EXE} apt-get install -y curl git gawk jq xz-utils
  11 | +# Lint dependencies:
  12 | +# - curl (to download shellcheck)

hebasto commented at 6:08 PM on January 17, 2023:

Mention xz-util? See #26716 (review)

maflcko force-pushed on Jan 17, 2023
hebasto approved
hebasto commented at 6:13 PM on January 17, 2023: member

ACK fa87d71872f1a6f85f5ac699290c45a6e3c8933a
fanquake merged this on Jan 18, 2023
fanquake closed this on Jan 18, 2023
maflcko deleted the branch on Jan 18, 2023
sidhujag referenced this in commit 959597a2a4 on Jan 18, 2023
bitcoin locked this on Jan 18, 2024

Contributors

Labels

ci: Add missing lint dependency (gpg) #26908

Reviews