depends: systemtap 4.8 #26945

1. 
   fanquake commented at 4:17 pm on January 22, 2023: member

   Updates systemtap to 4.8. Includes acc2895a66a4b654e9a0a05ed0927f67f48c75b2 from #25972. Will half (depends) fix #26916.

   Release notes etc: https://lwn.net/Articles/913908/.

2. fanquake added the label Build system on Jan 22, 2023
3. 
   DrahtBot commented at 4:17 pm on January 22, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto, 0xB10C

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #25972 (build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set by fanquake)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. depends: systemtap 4.8 a66d82e25f
5. fanquake force-pushed on Jan 23, 2023
6. fanquake marked this as ready for review on Jan 23, 2023
7. fanquake requested review from 0xB10C on Jan 23, 2023
8. 
   0xB10C commented at 12:31 pm on January 23, 2023: contributor

   ACK a91379359daca24b83b5e98714ec2fda93f24185

   Changes to the depends look good. Hash matches with what I get.

   Release notes etc: https://lwn.net/Articles/913908/.

   sourceware.org/PR29246 is relevant to us which is the only commit changing the includes/sys/sdt.h file. But it shouldn’t affect our use of sdt.h.

   I’ve previously checked that removing the problematic variadic in a patch does not cause any problems for us as we don’t use it. This also doesn’t conflict with #26593 as we use a different variadic there.

9. 
   hebasto commented at 2:20 pm on January 23, 2023: member

   Updates systemtap to 4.8. Includes acc2895 from #25972. Will half (depends) fix #26916.

   Not able to reproduce #26916 when building with depends on the master branch on Ubuntu 22.10:

   0$ make -C depends NO_QT=1 NO_WALLET=1 NO_ZMQ=1 NO_UPNP=1 NO_NATPMP=1
   1$ ./autogen.sh
   2$ ./configure CONFIG_SITE=$PWD/depends/x86_64-pc-linux-gnu/share/config.site CC=clang CXX=clang++
   3$ make clean
   4$ make
   5$ clang --version
   6Ubuntu clang version 15.0.2-1
   7Target: x86_64-pc-linux-gnu
   8Thread model: posix
   9InstalledDir: /usr/bin
   

   Is it a result of bumping to 4.8?

10. 
    fanquake commented at 2:21 pm on January 23, 2023: member

    Is it a result of bumping

    No it’s probably because you don’t have any warnings turned on.

11. 
    hebasto commented at 2:25 pm on January 23, 2023: member

    Is it a result of bumping

    No it’s probably because you don’t have any warnings turned on.

    Right… :man_facepalming:

12. in depends/patches/systemtap/fix_variadic_warning.patch:5 in a91379359d outdated

    0@@ -0,0 +1,13 @@
    1+diff --git a/includes/sys/sdt.h b/includes/sys/sdt.h
    2+index 4075a5f..7c6138c 100644
    3+--- a/includes/sys/sdt.h
    4++++ b/includes/sys/sdt.h
    5+@@ -278,7 +278,7 @@ __extension__ extern unsigned long long __sdt_unsp;
    

    ---

    ---

    

    hebasto commented at 2:53 pm on January 23, 2023:

    0@@ -276,7 +276,7 @@ __extension__ extern unsigned long long __sdt_unsp;
    

13. in depends/patches/systemtap/fix_variadic_warning.patch:13 in a91379359d outdated

     5+@@ -278,7 +278,7 @@ __extension__ extern unsigned long long __sdt_unsp;
     6+   _SDT_ASM_1(.purgem _SDT_TYPE_)					      \
     7+   _SDT_ASM_1(.purgem _SDT_TYPE)
     8+ 
     9+-#define _SDT_ASM_BODY(provider, name, pack_args, args, ...)		      \
    10++#define _SDT_ASM_BODY(provider, name, pack_args, args)		            \
    

    ---

    ---

    

    hebasto commented at 2:54 pm on January 23, 2023:

    Add a comment that this patch can be dropped after switching to C++20?

    ---

    

    fanquake commented at 6:12 pm on January 23, 2023:

    Added.
14. hebasto approved
15. 
    hebasto commented at 2:54 pm on January 23, 2023: member

    ACK a91379359daca24b83b5e98714ec2fda93f24185, tested on Ubuntu 22.10.
16. depends: systemtap: remove variadic params that trigger compiler warnings df7ae8b7ca
17. fanquake force-pushed on Jan 23, 2023
18. hebasto approved
19. 
    hebasto commented at 6:29 pm on January 23, 2023: member

    re-ACK df7ae8b7ca9cf53357d6a1c6bb70a2e40d2a1017.
20. 
    0xB10C commented at 2:37 pm on January 24, 2023: contributor

    ACK df7ae8b7ca9cf53357d6a1c6bb70a2e40d2a1017
21. fanquake merged this on Jan 26, 2023
22. fanquake closed this on Jan 26, 2023

    ---

23. fanquake deleted the branch on Jan 26, 2023
24. sidhujag referenced this in commit 53564628e1 on Jan 26, 2023
25. bitcoin locked this on Jan 26, 2024

Contributors
fanquake DrahtBot 0xB10C hebasto

Review Requested
0xB10C

Labels
Build system