Fixes #26797
Permit nodes to use -mintxfee=0. Values below 0 are handled by the ParseMoney() check.
wallet: permit mintxfee=0 #26955
pull willcl-ark wants to merge 1 commits into bitcoin:master from willcl-ark:2023-permit-zero-mintxfee changing 1 files +1 −1-
willcl-ark commented at 4:20 PM on January 23, 2023: contributor
-
f11eb1fe27
wallet: permit mintxfee=0
Fixes #26797 Permit nodes to use a mintxfee of `0` if they choose. Values below 0 are handled by the ParseMoney() check.
-
DrahtBot commented at 4:21 PM on January 23, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK MarcoFalke, john-moffett If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
- DrahtBot added the label Wallet on Jan 23, 2023
-
maflcko commented at 4:23 PM on January 23, 2023: member
review ACK f11eb1fe279c4a92e1bfc2c139e8838c73459d12
With the rationale copied from my comments in #26797
Looks like the
0check was added in 000dc55181f77cd96076c76b2cc13f8bcbe4146e for no reason?(Maybe it was added as belt-and-suspenders for calls that set
GMF_BLOCK, but none exist at that commit :man_shrugging: )Even if this is only useful for testing, handling
0different from0.00000001(or so) seems odd - john-moffett approved
-
john-moffett commented at 9:41 PM on January 23, 2023: contributor
ACK f11eb1fe279c4a92e1bfc2c139e8838c73459d12
No reason not to have this, since you can set
-blockmintxfeeto zero:I tested by doing a
sendtoaddresswith zero fee and it succeeded on this branch and failed on master (since I had to set a nonzero feerate). - fanquake merged this on Jan 24, 2023
- fanquake closed this on Jan 24, 2023
- sidhujag referenced this in commit 23154f9996 on Jan 24, 2023
- bitcoin locked this on Jan 24, 2024
