ci: Fetch no git history, unless lint #26977

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2301-ci-no-hist-🏥 changing 1 files +4 −1

maflcko commented at 12:50 PM on January 27, 2023: member

Should cut 20s from each build, with no downside?

This is possible since commit fad7281d7842f337932cf44e703fdd631230ddd6
DrahtBot commented at 12:50 PM on January 27, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK real-or-random

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Jan 27, 2023
maflcko force-pushed on Jan 27, 2023
ci: Fetch no git history, unless lint faa65f12fc
maflcko force-pushed on Jan 27, 2023
real-or-random approved
real-or-random commented at 4:07 PM on January 27, 2023: contributor

ACK faa65f12fc137231c0333330f670847473650028
fanquake merged this on Jan 27, 2023
fanquake closed this on Jan 27, 2023
sidhujag referenced this in commit a8f6755d31 on Jan 27, 2023
maflcko deleted the branch on Jan 28, 2023
hebasto commented at 6:09 PM on February 9, 2023: member
Apparently, this patch broke caching of depends subdirectories which use git rev-list -1 HEAD ./depends to detect whether a cache should be invalidated.

For example, https://api.cirrus-ci.com/v1/task/5585583192408064/logs/depends_built.log:
```
echo $CIRRUS_TASK_NAME $(git rev-list -1 HEAD ./depends)
32-bit + dash [gui] [CentOS 8] dc905f6c2a60961aee73578fd3092bf90b28409f

Cache miss for depends_built-8fd621cab3e906716ac5f0063b2bd29796bfe47bbc565c729e434be9c1c97a91! No script to populate with.
```
maflcko commented at 6:28 PM on February 9, 2023: member

Should use git rev-parse HEAD:depends instead? Or git ls-tree HEAD ./depends?

https://git-scm.com/docs/git-ls-tree

https://git-scm.com/docs/git-rev-parse#Documentation/git-rev-parse.txt-emltrevgtltpathgtemegemHEADREADMEememmasterREADMEem
hebasto commented at 8:21 AM on February 10, 2023: member

Should use git rev-parse HEAD:depends instead?

Thanks! Done in ##27070.
maflcko referenced this in commit 4f841cbb81 on Feb 10, 2023
bitcoin locked this on Jan 23, 2025

Type	Reviewers
ACK	real-or-random

Contributors

Labels

Linked (view graph)

#27070 ci: Fix `fingerprint_script` for `depends` subdir caches

ci: Fetch no git history, unless lint #26977

Reviews