explicit `-d/--delete` argument for verifybinaries/verify.py #26985

Use argparse (python buil-in) so that delete argument is explicit, instead of 'specify anything as the second parameter' user has to use -d/--delete to remove binaries after the check. Explicit is always better than implicit and I myself few times fat-fingered something behind the command and it deleted binaries that I wanted to keep. With this patch you get error for random things:

usage: verify.py [-h] [-d] VERSION
verify.py: error: unrecognized arguments: d

With argparse verify.py now has a nice help message that is handy for scripts:

usage: verify.py [-h] [-d] VERSION

Download and verify bitcoin binaries.

positional arguments:
  VERSION       Target version.

optional arguments:
  -h, --help    show this help message and exit
  -d, --delete  Delete the downloaded binaries afterwards.

I aslo fixed error in README which previously stated that If an error occurs the return value is 2. but correct is that it returns >= 2

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--021abf342d371248e50ceaed478a90ca-->

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #23020 (fix: contrib: allow multi-sig binary verification by jamesob)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Thanks, however this script needs much more work, to make it usable/useful, and this is already underway in #23020. Maybe you'd be interested in reviewing there instead? Going to close this for now.

didn't know about that, will have a look - thanks