psbt: s/transcation/transaction/ #26997

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:transcation changing 1 files +1 −1
  1. instagibbs commented at 3:47 pm on January 30, 2023: member
  2. s/transcation/transaction/ 906631450d
  3. DrahtBot commented at 3:47 pm on January 30, 2023: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK fanquake

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    No conflicts as of last run.

  4. maflcko renamed this:
    s/transcation/transaction/
    psbt: s/transcation/transaction/
    on Jan 30, 2023
  5. DrahtBot added the label PSBT on Jan 30, 2023
  6. in src/psbt.h:1167 in 906631450d
    1163@@ -1164,7 +1164,7 @@ struct PartiallySignedTransaction
    1164 
    1165         // Make sure that we got an unsigned tx
    1166         if (!tx) {
    1167-            throw std::ios_base::failure("No unsigned transcation was provided");
    1168+            throw std::ios_base::failure("No unsigned transaction was provided");
    


    jonatack commented at 3:58 pm on January 30, 2023:

    maybe also fix up this one that was recently added in 1429f8377017

    0$ ./test/lint/lint-spelling.py 
    1src/blockencodings.h:138: overriden ==> overridden
    

    jonatack commented at 6:13 pm on February 1, 2023:

    Another one now, may as well get ’em all in this fixup commit.

    0$ test/lint/lint-spelling.py 
    1src/blockencodings.h:138: overriden ==> overridden
    2src/net.cpp:1668: addressses ==> addresses
    
  7. fanquake approved
  8. fanquake commented at 9:39 am on February 16, 2023: member
    ACK 906631450df9927e690658184aa8a6b1b3a29ee9 - looks like other comments are being addressed elsewhere.
  9. fanquake merged this on Feb 16, 2023
  10. fanquake closed this on Feb 16, 2023

  11. sidhujag referenced this in commit 390e0f3023 on Feb 16, 2023
  12. bitcoin locked this on Feb 16, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-29 01:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me