depends: ensure we are appending to sqlite cflags #26998

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:msan_flags_missing changing 1 files +1 −1
  1. fanquake commented at 5:15 pm on January 30, 2023: member

    Otherwise we’ll just override other flags passed in (i.e msan).

    Should fix https://cirrus-ci.com/task/6598922274078720?logs=ci#L3661.

  2. depends: ensure we are appending to sqlite cflags
    Otherwise we'll just override other flags passed in (i.e msan).
    56a03f1834
  3. DrahtBot commented at 5:15 pm on January 30, 2023: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK TheCharlatan, achow101

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Build system on Jan 30, 2023
  5. fanquake marked this as ready for review on Jan 30, 2023
  6. TheCharlatan approved
  7. TheCharlatan commented at 9:27 pm on January 30, 2023: contributor

    ACK 56a03f1834a7437e3357923a1e45e512c9b2e6fc

    Also checked that this is done correctly for the other $(package)_*flags.

  8. achow101 commented at 9:57 pm on January 30, 2023: member
    ACK 56a03f1834a7437e3357923a1e45e512c9b2e6fc
  9. achow101 merged this on Jan 30, 2023
  10. achow101 closed this on Jan 30, 2023

  11. sidhujag referenced this in commit f1fb1730a4 on Jan 30, 2023
  12. fanquake deleted the branch on Jan 31, 2023
  13. bitcoin locked this on Jan 31, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me