guix: consolidate to glibc 2.27 for Linux builds

fanquake commented at 4:50 pm on February 2, 2023: member

Build against glibc 2.27 for all Linux builds (previously only used for RISC-V), and at the same time, increase our minimum required glibc to 2.27 (2018). This would drop support for Ubuntu Xenial (16.04) & Debian Stretch (9), from the produced release binaries. Compiling from source on those systems may be possible, assuming you can install a recent enough compiler/toolchain etc.

fanquake added the label Brainstorming on Feb 2, 2023

fanquake added the label DrahtBot Guix build requested on Feb 2, 2023

DrahtBot commented at 4:51 pm on February 2, 2023: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#25573 ([POC] guix: produce a fully -static-pie x86_64 bitcoind using GCC and glibc by fanquake)
#24123 (build: Pointer Authentication and Branch Target Identification for aarch64 Linux (Guix) by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

in contrib/devtools/symbol-check.py:20 in 1cc4d39675 outdated

14@@ -15,15 +15,15 @@
15 
16 import lief #type:ignore
17 
18-# Debian 9 (Stretch) EOL: 2022. https://wiki.debian.org/DebianReleases#Production_Releases
19+# Debian 10 (Buster) EOL: 2024. https://wiki.debian.org/LTS
20 #
21-# - g++ version 6.3.0 (https://packages.debian.org/search?suite=stretch&arch=any&searchon=names&keywords=g%2B%2B)
22-# - libc version 2.24 (https://packages.debian.org/search?suite=stretch&arch=any&searchon=names&keywords=libc6)
23+# - g++ version 8.3.0 (https://packages.debian.org/search?suite=stretch&arch=any&searchon=names&keywords=g%2B%2B)

maflcko commented at 5:03 pm on February 2, 2023:

0# - libgcc version 8.3.0 (https://packages.debian.org/search?suite=buster&arch=any&searchon=names&keywords=g%2B%2B)

maflcko commented at 5:06 pm on February 2, 2023:

why is g++ mentioned here at all? Isn’t this about glibc, a run-time dependency, whereas g++ is a compile time dependency?

fanquake commented at 4:23 pm on February 5, 2023:

We also have a runtime dependency on libgcc.

maflcko commented at 10:03 am on February 6, 2023:

Maybe clarify that for non-build people? (Changed my first comment)

fanquake commented at 1:22 pm on February 6, 2023:

Updated to mention libgcc instead.

in contrib/devtools/symbol-check.py:26 in 1cc4d39675 outdated

27+# Ubuntu 18.04 (Bionic) EOL: 2028. https://wiki.ubuntu.com/Releases
28 #
29-# - g++ version 5.3.1
30-# - libc version 2.23
31+# - g++ version 7.5.0
32+# - libc version 2.27

maflcko commented at 5:07 pm on February 2, 2023:

0# - libc version 2.27 (https://packages.ubuntu.com/bionic/libc6)

fanquake commented at 4:24 pm on February 5, 2023:

Added.

maflcko commented at 5:19 pm on February 2, 2023: member

For reference, this would affect less than 2% of snap users:

stats_feb2

in contrib/devtools/symbol-check.py:23 in 1cc4d39675 outdated

22-# - libc version 2.24 (https://packages.debian.org/search?suite=stretch&arch=any&searchon=names&keywords=libc6)
23+# - g++ version 8.3.0 (https://packages.debian.org/search?suite=stretch&arch=any&searchon=names&keywords=g%2B%2B)
24+# - libc version 2.28 (https://packages.debian.org/search?suite=stretch&arch=any&searchon=names&keywords=libc6)
25 #
26-# Ubuntu 16.04 (Xenial) EOL: 2026. https://wiki.ubuntu.com/Releases
27+# Ubuntu 18.04 (Bionic) EOL: 2028. https://wiki.ubuntu.com/Releases

hebasto commented at 10:10 am on February 3, 2023:

0# Ubuntu 18.04 (Bionic) EOL: 2028. https://wiki.ubuntu.com/ReleaseTeam

fanquake commented at 4:23 pm on February 5, 2023:

These seem to be basically the same content, but sure.

hebasto commented at 9:50 am on February 7, 2023:

These seem to be basically the same content

You are right. But at the time I checked the https://wiki.ubuntu.com/Releases link, it was not working for me. Now, both links work for me.

DrahtBot removed the label DrahtBot Guix build requested on Feb 3, 2023

fanquake force-pushed on Feb 5, 2023

fanquake force-pushed on Feb 6, 2023

luke-jr commented at 6:37 pm on February 6, 2023: member

This would drop support for Ubuntu Xenial (16.04) & Debian Stretch (9).

Only for the binaries, right? Building from source should still be possible, I’d expect. (Though I’m not sure if we care, it might be good to clarify in the description)

fanquake force-pushed on Feb 7, 2023

fanquake commented at 1:54 pm on February 7, 2023: member

(Though I’m not sure if we care, it might be good to clarify in the description)

Added a note to the PR description.

fanquake marked this as ready for review on Feb 7, 2023

hebasto commented at 2:18 pm on February 7, 2023: member

Concept ACK.

hebasto commented at 1:06 pm on February 10, 2023: member

Guix builds:

 0380420dbd00aa112f988bc7ab7e226f0662499d2008582bf325f47cc1a02a54d  guix-build-d1c8711d8a17/output/aarch64-linux-gnu/SHA256SUMS.part
 1e2b77aaac9a2fd67a8b66892083802b28163b97906efc352d98b03d43f8371ab  guix-build-d1c8711d8a17/output/aarch64-linux-gnu/bitcoin-d1c8711d8a17-aarch64-linux-gnu-debug.tar.gz
 2fec876f1039980d1706d938d2255d57ca6dd26163d4a31bee1704a0b7ebf90c6  guix-build-d1c8711d8a17/output/aarch64-linux-gnu/bitcoin-d1c8711d8a17-aarch64-linux-gnu.tar.gz
 3acaaf65a53ebe2259256c2f1bd01c818a8e5ae1b7d68b9e8c90505a5ca8496e5  guix-build-d1c8711d8a17/output/arm-linux-gnueabihf/SHA256SUMS.part
 49e88984b59284375590f6a58d91c6656bc01a3144ecf1f68b4745e2d47e26e14  guix-build-d1c8711d8a17/output/arm-linux-gnueabihf/bitcoin-d1c8711d8a17-arm-linux-gnueabihf-debug.tar.gz
 511bff60d541ccc8d397d05af90e425b0e29732f6dbc339343a0e7d1ac65f0968  guix-build-d1c8711d8a17/output/arm-linux-gnueabihf/bitcoin-d1c8711d8a17-arm-linux-gnueabihf.tar.gz
 6993e2493c407ea8c7dd5fccc98c849467b967001b4a1151d43c570bf767bc9bb  guix-build-d1c8711d8a17/output/arm64-apple-darwin/SHA256SUMS.part
 7bbe0c2faba5fccfccced9e888edad57c45fa6a7ee96e0d823186556f2ebf737f  guix-build-d1c8711d8a17/output/arm64-apple-darwin/bitcoin-d1c8711d8a17-arm64-apple-darwin-unsigned.dmg
 8ecbab86e1b70c66aae0cfc6591a47fa2ae478238ee0a5ca2506fbac653fee39b  guix-build-d1c8711d8a17/output/arm64-apple-darwin/bitcoin-d1c8711d8a17-arm64-apple-darwin-unsigned.tar.gz
 9f6c2410e5fd357b0f5c0ab46bc507904bd1ba31b1b2cfe8f183c21f20e2876dc  guix-build-d1c8711d8a17/output/arm64-apple-darwin/bitcoin-d1c8711d8a17-arm64-apple-darwin.tar.gz
109c395364e92ff5489a51aab82b5630b578391549bba6f3d82f6ca4b03171d6db  guix-build-d1c8711d8a17/output/dist-archive/bitcoin-d1c8711d8a17.tar.gz
11bd759857b26d0327e526efce9b6a5a93b12b427d2d948c9c16d363685bc565c4  guix-build-d1c8711d8a17/output/powerpc64-linux-gnu/SHA256SUMS.part
12e7cb396838cb16b450c6610731081f4796fc32bbe950a47362b122e318a67109  guix-build-d1c8711d8a17/output/powerpc64-linux-gnu/bitcoin-d1c8711d8a17-powerpc64-linux-gnu-debug.tar.gz
13f0cebc830796a431aa61fc92bfa49e4202d04cbfb5a4dad387e98de8beb12149  guix-build-d1c8711d8a17/output/powerpc64-linux-gnu/bitcoin-d1c8711d8a17-powerpc64-linux-gnu.tar.gz
146ec3fb20feb1ec195a0c875b881460f077d75ee9c76a84ff4e8ba5ab3f7a3a04  guix-build-d1c8711d8a17/output/powerpc64le-linux-gnu/SHA256SUMS.part
15c3bd6420a515f7a78a28b8556d017dc780c87b264d1709e68125fe5e416eaab7  guix-build-d1c8711d8a17/output/powerpc64le-linux-gnu/bitcoin-d1c8711d8a17-powerpc64le-linux-gnu-debug.tar.gz
1686a65f451ff949a35a15cbd6f6044b2da02c6c9ffb6a01b2115d676e5a1a2e2e  guix-build-d1c8711d8a17/output/powerpc64le-linux-gnu/bitcoin-d1c8711d8a17-powerpc64le-linux-gnu.tar.gz
172176716c09834e4ed1d64a9c5a7bc027a2ac7ad24282d225d938fcddacee7363  guix-build-d1c8711d8a17/output/riscv64-linux-gnu/SHA256SUMS.part
186f6f8855b06e907d62d5e514d9346cb9808a9168287fca4967d19bec6a04a0ee  guix-build-d1c8711d8a17/output/riscv64-linux-gnu/bitcoin-d1c8711d8a17-riscv64-linux-gnu-debug.tar.gz
1905dd291d58124f077df1308be7248e17421ca21139a7e0aae3ca55a7d7036e55  guix-build-d1c8711d8a17/output/riscv64-linux-gnu/bitcoin-d1c8711d8a17-riscv64-linux-gnu.tar.gz
20261bd1364f4c27c0f7ed3e6e2a47d1cc80b816cacc18bb5eaccb86925db055f0  guix-build-d1c8711d8a17/output/x86_64-apple-darwin/SHA256SUMS.part
214fd7bd4fced41f4a24411bbaf8547e0ffede07dcb3099ae405f637abce9a4b62  guix-build-d1c8711d8a17/output/x86_64-apple-darwin/bitcoin-d1c8711d8a17-x86_64-apple-darwin-unsigned.dmg
2251f93649501ffb4ad4aa8319a2554fb7241203472daae3589f6a1cd7d885b538  guix-build-d1c8711d8a17/output/x86_64-apple-darwin/bitcoin-d1c8711d8a17-x86_64-apple-darwin-unsigned.tar.gz
23edd5aaa6c9584a2dedf95616ca9bdd52ae2a348e77270bfdc1e12066da1c4d08  guix-build-d1c8711d8a17/output/x86_64-apple-darwin/bitcoin-d1c8711d8a17-x86_64-apple-darwin.tar.gz
24aef791b30bb3f4aa1998e50eff824a9ff3249b1e840405dcbc7d8af6a2253487  guix-build-d1c8711d8a17/output/x86_64-linux-gnu/SHA256SUMS.part
25b6c632ab1f667edb0e207f6692472207fbcaf8f8c2fae0369d8c1542ea981b02  guix-build-d1c8711d8a17/output/x86_64-linux-gnu/bitcoin-d1c8711d8a17-x86_64-linux-gnu-debug.tar.gz
26beea28998bd5d0e7b9984887bf5755e89d5b5e1ff1f84c05919520f72b1d115a  guix-build-d1c8711d8a17/output/x86_64-linux-gnu/bitcoin-d1c8711d8a17-x86_64-linux-gnu.tar.gz
27a0a2515afe79a7afb0f09ed10a03d3e30eb3185a4eeb7e26b833bd4f70cbbea9  guix-build-d1c8711d8a17/output/x86_64-w64-mingw32/SHA256SUMS.part
286aff5418a3a8b489ae4306619f459dce895095a792cb8a7e910e4c3d79552d71  guix-build-d1c8711d8a17/output/x86_64-w64-mingw32/bitcoin-d1c8711d8a17-win64-debug.zip
2934a32080c0f2ad2cb19c8bf0ef454fe3a745a746b68ff1dfcd5fe54fa8bc2188  guix-build-d1c8711d8a17/output/x86_64-w64-mingw32/bitcoin-d1c8711d8a17-win64-setup-unsigned.exe
30580ac9aa16c39341d6b8484cf73dd7c7f9b881e0dc17fd2c307f0e141fd59807  guix-build-d1c8711d8a17/output/x86_64-w64-mingw32/bitcoin-d1c8711d8a17-win64-unsigned.tar.gz
317ca12110fd33cedd661ac9336243465c3dfef23d398228a60e91746b255e32ed  guix-build-d1c8711d8a17/output/x86_64-w64-mingw32/bitcoin-d1c8711d8a17-win64.zip

in contrib/devtools/symbol-check.py:20 in d1c8711d8a outdated

14@@ -15,30 +15,30 @@
15 
16 import lief #type:ignore
17 
18-# Debian 9 (Stretch) EOL: 2022. https://wiki.debian.org/DebianReleases#Production_Releases
19+# Debian 10 (Buster) EOL: 2024. https://wiki.debian.org/LTS
20 #
21-# - g++ version 6.3.0 (https://packages.debian.org/search?suite=stretch&arch=any&searchon=names&keywords=g%2B%2B)
22-# - libc version 2.24 (https://packages.debian.org/search?suite=stretch&arch=any&searchon=names&keywords=libc6)
23+# - libgcc version 8.3.0 (https://packages.debian.org/search?suite=buster&arch=any&searchon=names&keywords=g%2B%2B)

hebasto commented at 3:02 pm on February 10, 2023:

0# - libgcc version 8.3.0 (https://packages.debian.org/search?suite=buster&arch=any&searchon=names&keywords=libgcc1)

fanquake commented at 1:57 pm on February 13, 2023:

Done

in contrib/devtools/symbol-check.py:25 in d1c8711d8a outdated

26-# Ubuntu 16.04 (Xenial) EOL: 2026. https://wiki.ubuntu.com/Releases
27+# Ubuntu 18.04 (Bionic) EOL: 2028. https://wiki.ubuntu.com/ReleaseTeam
28 #
29-# - g++ version 5.3.1
30-# - libc version 2.23
31+# - libgcc version 7.4.0 (https://packages.ubuntu.com/bionic/gcc)

hebasto commented at 3:07 pm on February 10, 2023:

A link should point at https://packages.ubuntu.com/bionic/libgcc1. But it is libgcc-8.4, not 7.4.

fanquake commented at 1:57 pm on February 13, 2023:

Done

in contrib/guix/manifest.scm:581 in d1c8711d8a outdated

557@@ -577,8 +558,9 @@ inspecting signatures in Mach-O binaries.")
558                (base32
559                 "1b2n1gxv9f4fd5yy68qjbnarhf8mf4vmlxk10i3328c1w5pmp0ca"))
560               (patches (search-our-patches "glibc-ldd-x86_64.patch"
561+                                           "glibc-versioned-locpath.patch"
562                                            "glibc-2.27-riscv64-Use-__has_include-to-include-asm-syscalls.h.patch"
563-                                           "glibc-2.27-dont-redefine-nss-database.patch"

hebasto commented at 3:14 pm on February 10, 2023:

Why dropping the glibc-2.27-dont-redefine-nss-database.patch is safe?

fanquake commented at 2:23 pm on February 13, 2023:

The patch is included in the branch. I’ve also bumped the branch to be the head of the current 2.27 release branch, which contains some additional backported fixes.

fanquake force-pushed on Feb 13, 2023

guix: use glibc 2.27 for all Linux builds

Also point to the latest commit on the glibc 2.27 releases branch.

https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/release/2.27/master

74c9893989

guix: remove no-longer needed powerpc workaround c49f2b8eb5

guix: combine glibc hardening options into hardened-glibc d5d4b75840

fanquake force-pushed on Feb 13, 2023

fanquake added the label DrahtBot Guix build requested on Feb 13, 2023

bitcoin deleted a comment on Feb 13, 2023

DrahtBot commented at 8:38 am on February 14, 2023: contributor

Guix builds

File	commit 8126551d54ffd290ed5767248be4b3d19243787b(master)	commit 957f75a3da9a8fcf9f3a6058b4f13a646150554d(master and this pull)
SHA256SUMS.part	`a73068811366a45b...`	`0feb34932bab5047...`
*-aarch64-linux-gnu-debug.tar.gz	`7d6dbd46fe457676...`	`dd699b9597abbd1d...`
*-aarch64-linux-gnu.tar.gz	`7520e7a059cc6684...`	`a46ee1d8481c1378...`
*-arm-linux-gnueabihf-debug.tar.gz	`d97bb1418d3b2316...`	`78a659fa032201c8...`
*-arm-linux-gnueabihf.tar.gz	`a1f0448968727793...`	`2346a7c7c19f7d08...`
*-arm64-apple-darwin-unsigned.dmg	`19533f717272f916...`	`c84e24017cfdd259...`
*-arm64-apple-darwin-unsigned.tar.gz	`57aff0ec6005a6db...`	`6a9d56a52e60ea87...`
*-arm64-apple-darwin.tar.gz	`862c6afeee71f8fb...`	`e9922cb5c63d7b3e...`
*-powerpc64-linux-gnu-debug.tar.gz	`4b643f0b06967242...`	`5c3881c39a9705c5...`
*-powerpc64-linux-gnu.tar.gz	`2670bee5edf6c3b8...`	`a70ff0cc80d1192f...`
*-powerpc64le-linux-gnu-debug.tar.gz	`6270c7d026c419f7...`	`bba55696abbf1cf0...`
*-powerpc64le-linux-gnu.tar.gz	`e3e4232270ff5aef...`	`bfde6ce9d895a8dc...`
*-riscv64-linux-gnu-debug.tar.gz	`f40af1d070e277c7...`	`4a0178ad468c88c3...`
*-riscv64-linux-gnu.tar.gz	`110762f167d43d69...`	`68bb2cd75fb79e39...`
*-win64-debug.zip	`4ac7737d97907d51...`	`08ae361ea1f0a8aa...`
*-win64-setup-unsigned.exe	`859d32a0947d4da7...`	`8145dca946e90d63...`
*-win64-unsigned.tar.gz	`f43a32fecc0c1eee...`	`35dbfa54222ab803...`
*-win64.zip	`1cdb7f63ef9f70b2...`	`44c396b62f77af23...`
*-x86_64-apple-darwin-unsigned.dmg	`034a7debb3f5adbf...`	`89fb30f742f9016d...`
*-x86_64-apple-darwin-unsigned.tar.gz	`f441fb040d56859a...`	`bcf003d38d1fcb65...`
*-x86_64-apple-darwin.tar.gz	`79b5f8787c6a3720...`	`fda1b1140a7cc4da...`
*-x86_64-linux-gnu-debug.tar.gz	`e2dc9354ef2e4819...`	`f48883fe397b5f60...`
*-x86_64-linux-gnu.tar.gz	`185e3a914236c77c...`	`b2cc85a3bb95edb9...`
*.tar.gz	`3daf687b07d336f1...`	`ceff29304bb13ee7...`
guix_build.log	`57232e42a42fca6d...`	`7c14bdc95c329da0...`
guix_build.log.diff		`9651c6ad07fd1455...`

DrahtBot removed the label DrahtBot Guix build requested on Feb 14, 2023

hebasto commented at 12:26 pm on February 14, 2023: member

Guix builds:

 0851f4116c395a6b89475871a9763a111abad3951424276135931d80b1c09615e  guix-build-d5d4b75840b4/output/aarch64-linux-gnu/SHA256SUMS.part
 1bb9d3867b8f7dae5f9f8c326aa1b0e9fa28964659b3c7187e743152044c9dbe8  guix-build-d5d4b75840b4/output/aarch64-linux-gnu/bitcoin-d5d4b75840b4-aarch64-linux-gnu-debug.tar.gz
 2e4c0ab4883993362aea104ea776102a5d5beaa39a22e9aa22fd27a81d36415dc  guix-build-d5d4b75840b4/output/aarch64-linux-gnu/bitcoin-d5d4b75840b4-aarch64-linux-gnu.tar.gz
 301b239015610aea0c4767f05f0222d06a6d99a9e5f92556a381274125c6d66a8  guix-build-d5d4b75840b4/output/arm-linux-gnueabihf/SHA256SUMS.part
 4e804a1c26a10968002ca0cb2014ff88c7ec537d000f0dbc860aae808bff6f450  guix-build-d5d4b75840b4/output/arm-linux-gnueabihf/bitcoin-d5d4b75840b4-arm-linux-gnueabihf-debug.tar.gz
 5e8e3bc689ed683ff8df9d6774e87fe16ff67b4ed1a74388b628a59a4ef487e5e  guix-build-d5d4b75840b4/output/arm-linux-gnueabihf/bitcoin-d5d4b75840b4-arm-linux-gnueabihf.tar.gz
 6d575b2a4eb2775442215f51e6a93ce074c1c115560bd4341cc70a7406345fe41  guix-build-d5d4b75840b4/output/arm64-apple-darwin/SHA256SUMS.part
 749e2ad01a1eb9b8862546676d97a8440a64a90b2422f2fe600d25eb1006a1e8e  guix-build-d5d4b75840b4/output/arm64-apple-darwin/bitcoin-d5d4b75840b4-arm64-apple-darwin-unsigned.dmg
 8d244822ad0b5f766cb1a834676a482fc9927dea49c105da2ac61327c4ed658aa  guix-build-d5d4b75840b4/output/arm64-apple-darwin/bitcoin-d5d4b75840b4-arm64-apple-darwin-unsigned.tar.gz
 9fa2828d641e8e252d3988dff1ebcef65ce6a998a24c0508b533fb07637671c72  guix-build-d5d4b75840b4/output/arm64-apple-darwin/bitcoin-d5d4b75840b4-arm64-apple-darwin.tar.gz
10d46fdade6a94cf9ebeb09fc7a5505e9778aa580eb5be83445f3a969dec7e585f  guix-build-d5d4b75840b4/output/dist-archive/bitcoin-d5d4b75840b4.tar.gz
11fcf67a8fdb1985c7cff9770a18c32d83793af254dbb64589a3da52e0399949b3  guix-build-d5d4b75840b4/output/powerpc64-linux-gnu/SHA256SUMS.part
1291aa7d168ad8f7a997d278c6834b7783e7e3e5e8d8fbc1a82d055dd1f2ff2721  guix-build-d5d4b75840b4/output/powerpc64-linux-gnu/bitcoin-d5d4b75840b4-powerpc64-linux-gnu-debug.tar.gz
1330829f413c94c304432a0f5cbbc35765e5361df90044a2cb53b6aabd5b510e2e  guix-build-d5d4b75840b4/output/powerpc64-linux-gnu/bitcoin-d5d4b75840b4-powerpc64-linux-gnu.tar.gz
14aa6769922b749214879a17b1ed1de2d7d320c9e41393315043851a89d15663ab  guix-build-d5d4b75840b4/output/powerpc64le-linux-gnu/SHA256SUMS.part
151e9ffb7fd8bdf98c9e67b70c1b93923e15b710c46337ce4c99bb7b3daf09470a  guix-build-d5d4b75840b4/output/powerpc64le-linux-gnu/bitcoin-d5d4b75840b4-powerpc64le-linux-gnu-debug.tar.gz
169def5193a9d7d68692775674309f9d9845beda30cf8063a24b9b8973a861f269  guix-build-d5d4b75840b4/output/powerpc64le-linux-gnu/bitcoin-d5d4b75840b4-powerpc64le-linux-gnu.tar.gz
17c0b222629fea85695928dbd16e5c0e72c79696900a0146c40042322f2f01814f  guix-build-d5d4b75840b4/output/riscv64-linux-gnu/SHA256SUMS.part
184df06befb42b863bd95c1f8a4eb20e17301b09c13d86ebbe1ba7955e2a8fe6bc  guix-build-d5d4b75840b4/output/riscv64-linux-gnu/bitcoin-d5d4b75840b4-riscv64-linux-gnu-debug.tar.gz
19b7fea7a60658295c2f4474041a79ea1e26761616edc37e89ab98d9805f1886a4  guix-build-d5d4b75840b4/output/riscv64-linux-gnu/bitcoin-d5d4b75840b4-riscv64-linux-gnu.tar.gz
2048e84106393c6f1b289fe2e0df313bfa7a42b2f3b896b291e41dcf002da31c9f  guix-build-d5d4b75840b4/output/x86_64-apple-darwin/SHA256SUMS.part
21c4dca1fbe3ff37f6a04987e064ac8a6decdba2982553f8bbbccc3d5aaeb78ef2  guix-build-d5d4b75840b4/output/x86_64-apple-darwin/bitcoin-d5d4b75840b4-x86_64-apple-darwin-unsigned.dmg
22753214c4afd588e3e667f29e14d21994549b26f0e1e2128d5a9e7010f3a07011  guix-build-d5d4b75840b4/output/x86_64-apple-darwin/bitcoin-d5d4b75840b4-x86_64-apple-darwin-unsigned.tar.gz
234b8d9cb9d23bde32093a21b5b7faddd8b5ef7bbf5a30337168bb4d444ddd1ac5  guix-build-d5d4b75840b4/output/x86_64-apple-darwin/bitcoin-d5d4b75840b4-x86_64-apple-darwin.tar.gz
242da36961e66d3c187f8ac528b5071f32dd411297da832bd30d0d824ada33ba03  guix-build-d5d4b75840b4/output/x86_64-linux-gnu/SHA256SUMS.part
2555c26b8cdac8dc858700719b4a6f7b9da7da3c433c66332acb0ac13070bcbf1f  guix-build-d5d4b75840b4/output/x86_64-linux-gnu/bitcoin-d5d4b75840b4-x86_64-linux-gnu-debug.tar.gz
269fed647746e45b19cc34c1f92e9f0690362b994a806a9278c569854ad8058d89  guix-build-d5d4b75840b4/output/x86_64-linux-gnu/bitcoin-d5d4b75840b4-x86_64-linux-gnu.tar.gz
27058d79d1865dfe7f7ae45b9d12c5fa2edf4c00fedfabfbb3d16d0e4b6c65be6a  guix-build-d5d4b75840b4/output/x86_64-w64-mingw32/SHA256SUMS.part
2887f43c510ad32405aa70c7d26facd01cb865068f72f8c6025748ef9b991c21fb  guix-build-d5d4b75840b4/output/x86_64-w64-mingw32/bitcoin-d5d4b75840b4-win64-debug.zip
29d14ebf78778522b79abdbd19451ff2326452e909a4223ea31d964b0e231d29c4  guix-build-d5d4b75840b4/output/x86_64-w64-mingw32/bitcoin-d5d4b75840b4-win64-setup-unsigned.exe
3091e6baa2f53f86d3835e730d82dde8a760bcdf91c3d9c2501ab4714e518c3123  guix-build-d5d4b75840b4/output/x86_64-w64-mingw32/bitcoin-d5d4b75840b4-win64-unsigned.tar.gz
3138355434457d7d4fd64e771b62f1033f53bb3f3346197b0ffaafab270fdf37e6  guix-build-d5d4b75840b4/output/x86_64-w64-mingw32/bitcoin-d5d4b75840b4-win64.zip

in contrib/devtools/test-symbol-check.py:65 in d5d4b75840

60-        ''')
61-
62-        self.assertEqual(call_symbol_check(cc, source, executable, ['-lm']),
63-                (1, executable + ': symbol nextup from unsupported version GLIBC_2.24(3)\n' +
64-                    executable + ': failed IMPORTED_SYMBOLS'))
65-

hebasto commented at 5:12 pm on February 15, 2023:

Instead of removing this test entirely, maybe replace it with a symbol which was introduced in glibc 2.28?

For example,

 0        with open(source, 'w', encoding="utf8") as f:
 1            f.write('''
 2                #define _GNU_SOURCE
 3                #include <unistd.h>
 4                #include <fcntl.h>
 5
 6                int main()
 7                {
 8                    fcntl64(0, F_GETFD);
 9                    return 0;
10                }
11        ''')
12
13        self.assertEqual(call_symbol_check(cc, source, executable, []),
14                (1, executable + ': symbol fcntl64 from unsupported version GLIBC_2.28(3)\n' +
15                    executable + ': failed IMPORTED_SYMBOLS'))

fanquake commented at 5:15 pm on February 15, 2023:

How will we compile that in a glibc 2.27 environment?

hebasto commented at 5:19 pm on February 15, 2023:

How will we compile that in a glibc 2.27 environment?

Right… :man_facepalming:

hebasto approved

hebasto commented at 5:41 pm on February 15, 2023: member

ACK d5d4b75840b4219495ed0fc421a4b71e757224ee, I have reviewed the code and it looks OK, I agree it can be merged.

fanquake merged this on Feb 17, 2023

fanquake closed this on Feb 17, 2023

fanquake deleted the branch on Feb 17, 2023

sidhujag referenced this in commit 6d0ae672ab on Feb 17, 2023

kwvg referenced this in commit 82bd1ad65c on May 13, 2023

kwvg referenced this in commit e99f3c7e38 on May 13, 2023

kwvg referenced this in commit 1b3c328e17 on May 13, 2023

kwvg referenced this in commit c42eb269d1 on May 19, 2023

kwvg referenced this in commit 37fea8023d on May 31, 2023

kwvg referenced this in commit 6a1ce609de on May 31, 2023

kwvg referenced this in commit 7a1c6c1042 on Jun 3, 2023

kwvg referenced this in commit c4c33ebe79 on Jun 6, 2023

kwvg referenced this in commit 42b36cfed6 on Jun 7, 2023

kwvg referenced this in commit c4d8268fda on Jun 8, 2023

kwvg referenced this in commit 1a3bd3964a on Jun 10, 2023

kwvg referenced this in commit 823904fb30 on Jun 11, 2023

kwvg referenced this in commit 8535e21b33 on Jun 11, 2023

kwvg referenced this in commit 3a0b9bd388 on Jun 11, 2023

kwvg referenced this in commit 1715a9966d on Jun 19, 2023

kwvg referenced this in commit caf67cf11a on Jun 20, 2023

kwvg referenced this in commit 029a8013ac on Jun 20, 2023

kwvg referenced this in commit 22d7dda117 on Jun 20, 2023

kwvg referenced this in commit 425bfaeaa5 on Jun 20, 2023

kwvg referenced this in commit f19692e888 on Jun 20, 2023

kwvg referenced this in commit 76c0b9f26e on Jun 20, 2023

kwvg referenced this in commit 0a7e3ff204 on Jun 29, 2023

kwvg referenced this in commit d7d28c00b5 on Jun 29, 2023

kwvg referenced this in commit 33ea00cd79 on Jun 30, 2023

kwvg referenced this in commit 5c6a3b8ce1 on Jun 30, 2023

kwvg referenced this in commit 849967fd83 on Jul 3, 2023

kwvg referenced this in commit 44819299a6 on Jul 4, 2023

kwvg referenced this in commit cdd4564a4a on Jul 9, 2023

kwvg referenced this in commit 32013b9400 on Jul 10, 2023

kwvg referenced this in commit bdd86b6ba0 on Jul 28, 2023

UdjinM6 referenced this in commit 46f3d46c55 on Jul 30, 2023

PastaPastaPasta referenced this in commit 04d77f72e9 on Aug 1, 2023

bitcoin locked this on Feb 17, 2024

guix: consolidate to glibc 2.27 for Linux builds #27029

Reviews

Conflicts

Guix builds