test: Fix intermittent sync issue in wallet_pruning #27066

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2302-test-fix-🍾 changing 1 files +5 −4
  1. maflcko commented at 11:31 AM on February 9, 2023: member

    Setting the mocktime on each loop iteration will make net processing racy and cause a disconnect due to timeout.

    Fix that by setting the mocktime only once.

    Fixes https://github.com/bitcoin/bitcoin/issues/27065

  2. test: Fix intermittent sync issue in wallet_pruning fa6f67837b
  3. DrahtBot commented at 11:31 AM on February 9, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK brunoerg

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Feb 9, 2023
  5. brunoerg approved
  6. brunoerg commented at 9:14 PM on February 9, 2023: contributor

    crACK fa6f67837b08a808cdd72856ac24cc932863daf4

  7. maflcko merged this on Feb 10, 2023
  8. maflcko closed this on Feb 10, 2023

  9. maflcko deleted the branch on Feb 10, 2023
  10. sidhujag referenced this in commit 6ae4b95e82 on Feb 10, 2023
  11. mzumsande commented at 10:56 PM on February 10, 2023: contributor
  12. maflcko commented at 4:31 PM on February 13, 2023: member

    https://cirrus-ci.com/task/5441089956478976 cry

    Ah, good catch. This is the still exactly the same error as in #27065. While the fix here is unrelated to fixing that bug, I think it is still needed to fix the same bug happening in a different line.

  13. maflcko commented at 4:33 PM on February 13, 2023: member
  14. fanquake referenced this in commit af49d86dd7 on Feb 14, 2023
  15. bitcoin locked this on Feb 13, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-24 09:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me