refactor: don’t avoid sys/types.h when building for Windows #27098

1. 
   fanquake commented at 3:29 pm on February 14, 2023: member

   We’ve already used it unguarded in httpserver.cpp for years, with no build issues.

   Doesn’t touch the usage in wallet/bdb.cpp. See #26832.

2. refactor: don't avoid sys/types.h on when building for Windows

   We've already used it unguarded in `httpserver.cpp` for years, with no
   build issues.

   8c38e56324
3. 
   DrahtBot commented at 3:29 pm on February 14, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. DrahtBot added the label Refactoring on Feb 14, 2023
5. 
   hebasto commented at 3:43 pm on February 14, 2023: member

   don’t avoid sys/types.h on when building for Windows

   Do Windows builds require any symbols from <sys/types.h>? If not, why churn the code?

6. 
   fanquake commented at 3:45 pm on February 14, 2023: member

   Does Windows builds require any symbols from <sys/types.h>?

   Aside from ultimately removing pointless per-platform conditionals,

   See #26832.

7. maflcko renamed this:
   refactor: don't avoid sys/types.h on when building for Windows
   refactor: don't avoid sys/types.h when building for Windows
   on Feb 14, 2023
8. 
   hebasto commented at 3:51 pm on February 14, 2023: member

   Aside from ultimately removing pointless per-platform conditionals,

   But this change does not remove per-platform conditionals.

   See #26832.

   Yes, I agree with cc16ab13f42b83672030fdd03c65fe27699854ee from #26832.

9. 
   fanquake commented at 3:52 pm on February 14, 2023: member

   But this change does not remove per-platform conditionals.

   Yea, that’s because this is a step towards doing so.

10. 
    fanquake commented at 2:39 pm on February 17, 2023: member

    Just going to combine this into #26832.
11. fanquake closed this on Feb 17, 2023

    ---

12. fanquake deleted the branch on Feb 17, 2023
13. bitcoin locked this on Feb 17, 2024

Contributors
fanquake DrahtBot hebasto

Labels
Refactoring