Fixes #26808
When node0 calls disconnectnode to disconnect node1, we should check in node1 if it worked, because for node0 the informations in getpeerinfo may be updated before really completing the disconnection.
test: fix intermittent issue in `p2p_disconnect_ban` #27128
pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2023-02-fix-ban-test-issue changing 1 files +2 −2-
brunoerg commented at 1:37 PM on February 20, 2023: contributor
-
1819564c21
test: fix intermittent issue in `p2p_disconnect_ban`
When `node0` calls `disconnectnode` to disconnect `node1`, we should check in `node1` if it worked, because for `node0` the informations in `getpeerinfo` may be updated before really completing the disconnection.
-
DrahtBot commented at 1:37 PM on February 20, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK MarcoFalke If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Feb 20, 2023
-
maflcko commented at 2:53 PM on February 20, 2023: member
lgtm ACK 1819564c2130d4d8537ca433c6688b56c769fb79
- fanquake merged this on Feb 20, 2023
- fanquake closed this on Feb 20, 2023
- sidhujag referenced this in commit c37110e733 on Feb 25, 2023
- bitcoin locked this on Feb 20, 2024
Labels