deserialize_v2 function (test_framework) should be able to deseriablize all networks presented in BIP155 (e.g. onion, ipv6, etc), however, it only works for ipv4 and i2p. I noticed that when I was using message-capture-parser and realized that most addrv2 messages weren't able to be deserialized.
Add support for all networks in `deserialize_v2` in test_framework #27140
issue brunoerg opened this issue on February 21, 2023-
brunoerg commented at 8:06 PM on February 21, 2023: contributor
- brunoerg added the label Feature on Feb 21, 2023
-
brunoerg commented at 8:07 PM on February 21, 2023: contributor
ooops, it added
featurelabel but i think it should bebug - fanquake removed the label Feature on Feb 22, 2023
- fanquake added the label Tests on Feb 22, 2023
-
fanquake commented at 11:09 AM on February 24, 2023: member
Can probably just be done when some code is added that would actually use the functionality? Going to close this for now.
- fanquake closed this on Feb 24, 2023
-
brunoerg commented at 11:24 AM on February 24, 2023: contributor
Can probably just be done when some code is added that would actually use the functionality? Going to close this for now. @fanquake. Sorry for not specifying but 'message-capture-parser' is not able to deserialize some addrv2 messages because of it. So, could we leave this issue opened?
- fanquake reopened this on Feb 24, 2023
- fanquake closed this on Aug 2, 2023
- timemarkovqtum referenced this in commit 2fa60f0b68 on Jan 30, 2024
- bitcoin locked this on Aug 1, 2024
