test: Replace 0xC0 constant #27143

pull roconnor-blockstream wants to merge 1 commits into bitcoin:master from roconnor-blockstream:patch-2 changing 1 files +11 −7

roconnor-blockstream commented at 2:06 PM on February 22, 2023: contributor

Instead it should be the named constant LEAF_VERSION_TAPSCRIPT.
DrahtBot commented at 2:07 PM on February 22, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK instagibbs, theStack

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Feb 22, 2023
instagibbs commented at 2:16 PM on February 22, 2023: member

Since we're already here, we could replace the rest of the instances of this variable too?
roconnor-blockstream commented at 2:19 PM on February 22, 2023: contributor

I am not aware of other instances.
instagibbs commented at 2:41 PM on February 22, 2023: member

here and script_lists a few lines below it https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_taproot.py#L1548
roconnor-blockstream commented at 2:55 PM on February 22, 2023: contributor

lol I'm embarrassed to say, I was only looking at Elements code.
roconnor-blockstream force-pushed on Feb 22, 2023

Type	Reviewers
ACK	instagibbs, theStack

test: Replace 0xC0 constant

Instead it should be the named constant `LEAF_VERSION_TAPSCRIPT`.

c3b4b5a142

roconnor-blockstream force-pushed on Feb 22, 2023
roconnor-blockstream commented at 3:29 PM on February 22, 2023: contributor

Updated. I've left VALID_LEAF_VERS alone because, logically speaking, the definition of the valid tapleaf versions (defined in BIP-341) is independent of the choice of which tapleaf version to assign to tapscript (defined in BIP-342).
instagibbs commented at 3:41 PM on February 22, 2023: member

ACK https://github.com/bitcoin/bitcoin/pull/27143/commits/c3b4b5a142b204ceeca4e9b1ca1e2ff41ddd1308
theStack approved
theStack commented at 5:50 PM on February 22, 2023: contributor

ACK c3b4b5a142b204ceeca4e9b1ca1e2ff41ddd1308
fanquake merged this on Feb 22, 2023
fanquake closed this on Feb 22, 2023
roconnor-blockstream deleted the branch on Feb 22, 2023
sidhujag referenced this in commit 57031c1ecb on Feb 25, 2023
bitcoin locked this on Feb 22, 2024

Contributors

Labels