interpreter: split PrecomputedTransactionData::Init() or rename force #27152

issue fanquake openend this issue on February 24, 2023
  1. fanquake commented at 9:33 am on February 24, 2023: member

    Potential followup from #27122#pullrequestreview-1307630323:

    I do wonder if it makes sense to rename force to something like signing_context or even more drastically split Init up into two obvious types ConsensusInit/SigningInit to make things clearer to future readers.

    Seems like there might also be scope to make some of the Init() inline commentary clearer, given other review comments in #27122.

    cc @instagibbs @ajtowns @roconnor-blockstream. If there is agreement on doing this, lets open a change, otherwise we can close this issue.

  2. fanquake added the label Brainstorming on Feb 24, 2023
  3. fanquake added the label Consensus on Feb 24, 2023
  4. instagibbs commented at 2:29 pm on February 24, 2023: member
    I obviously agree with myself, will let others chime in
  5. fanquake deleted a comment on Feb 25, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-28 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me