interpreter: split PrecomputedTransactionData::Init() or rename `force` #27152

issue fanquake openend this issue on February 24, 2023

fanquake commented at 9:33 am on February 24, 2023: member

Potential followup from #27122#pullrequestreview-1307630323:

I do wonder if it makes sense to rename force to something like signing_context or even more drastically split Init up into two obvious types ConsensusInit/SigningInit to make things clearer to future readers.

Seems like there might also be scope to make some of the Init() inline commentary clearer, given other review comments in #27122.

cc @instagibbs @ajtowns @roconnor-blockstream. If there is agreement on doing this, lets open a change, otherwise we can close this issue.
fanquake added the label Brainstorming on Feb 24, 2023
fanquake added the label Consensus on Feb 24, 2023
instagibbs commented at 2:29 pm on February 24, 2023: member

I obviously agree with myself, will let others chime in
bitcoin deleted a comment on Feb 25, 2023
willcl-ark commented at 3:08 pm on October 14, 2024: member

Closing this as it has not had any activity in a while. If you are interested in continuing discussion on this, or you feel that it is sufficiently important, please leave a comment so that it can be reopened.
willcl-ark closed this on Oct 14, 2024

interpreter: split PrecomputedTransactionData::Init() or rename force #27152