If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Conflicts
Reviewers, this pull request conflicts with the following ones:
#27099 (build: produce a .zip for macOS distribution by fanquake)
#21778 (build: LLVM 15 & LLD based macOS toolchain by fanquake)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
hebasto
commented at 10:28 am on February 28, 2023:
member
Concept ACK.
TheCharlatan
commented at 10:34 am on February 28, 2023:
contributor
Concept ACK
guix: use bash-minimal over bash4445621415
guix: use coreutils-minimal over coreutils1475515312
guix: use cmake-minimal over cmake2c9eb4afe1
fanquake force-pushed
on Feb 28, 2023
fanquake
commented at 12:20 pm on February 28, 2023:
member
Updated to also switch to cmake-minimal in the macOS builds.
hebasto approved
hebasto
commented at 1:59 pm on February 28, 2023:
member
maflcko
commented at 2:54 pm on February 28, 2023:
member
Is there an intuition on how much space this will save? Also, it might be good to check the binaries are identical (mod the commit id) before and after?
TheCharlatan
commented at 3:07 pm on February 28, 2023:
contributor
fanquake
commented at 3:07 pm on February 28, 2023:
member
Is there an intuition on how much space this will save?
Maybe 10’s of megabytes (will get you a number). Saving any space is a nice side-effect, but isn’t the primary goal here. The goal is to remove things that are not required in the release build environment, from the release build envionronment. Using available *-minimal packages also better communicates the intent of creating a minimal build env.
I would also assume this makes any bootstrapping paths less complicated, as any tools/dependencies that would otherwise be required to build/compile optional features we don’t need, no-longer have to be built as part of any toolchain.
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2024-12-03 15:12 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me