ci: bump lint task to bookworm for git v2.38 #27174

1. 
   glozow commented at 11:39 AM on February 28, 2023: member

   Since 5497c14, verify-commits.py uses git merge-tree which requires git v2.38 or later. Fix the lint jobs on master (e.g. https://cirrus-ci.com/task/4971007513985024).

2. glozow requested review from achow101 on Feb 28, 2023
3. 
   DrahtBot commented at 11:39 AM on February 28, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	achow101, hebasto
   Stale ACK	MarcoFalke

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. hebasto approved
5. 
   hebasto commented at 12:12 PM on February 28, 2023: member

   ACK 836720e366f61f23c7a56775e11d58890b002d75

6. in .cirrus.yml:67 in 836720e366 outdated

     60 | @@ -61,10 +61,10 @@ compute_credits_template: &CREDITS_TEMPLATE
     61 |    use_compute_credits: $CIRRUS_REPO_FULL_NAME == 'bitcoin/bitcoin' && $CIRRUS_PR != ""
     62 |  
     63 |  task:
     64 | -  name: 'lint [jammy]'
     65 | +  name: 'lint [lunar]'
     66 |    << : *BASE_TEMPLATE
     67 |    container:
     68 | -    image: ubuntu:jammy
     69 | +    image: ubuntu:lunar
   

   ---

   ---

   

   maflcko commented at 12:27 PM on February 28, 2023:

   This will reach EOL in about a year and thus fail CI tasks when the tag is deleted. What about using https://packages.debian.org/bookworm/git ?

   ---

   

   glozow commented at 2:22 PM on February 28, 2023:

   makes sense to me if bookworm is stable

   ---

   

   maflcko commented at 2:47 PM on February 28, 2023:

   Yes, the debian tag should be more stable than lunar, because it should be around for ~3 years, as opposed to ~1 year for lunar, looking at how long docker hub kept them historically.

   (Can be marked as resolved)

7. glozow force-pushed on Feb 28, 2023
8. [ci] change lint to bookworm for git v2.38

   Since 5497c14, verify-commits.py requires git merge-tree which is only
   available in git v2.38 or later.

   a984beeca1
9. 
   maflcko commented at 2:43 PM on February 28, 2023: member

   lgtm ACK 257dfef897db0ece387511d0592076381aaeff2b

   The title and commit message can be adjusted to ci: ..., if you retouch

10. glozow force-pushed on Feb 28, 2023
11. DrahtBot requested review from hebasto on Feb 28, 2023
12. 
    glozow commented at 2:44 PM on February 28, 2023: member

    lgtm ACK https://github.com/bitcoin/bitcoin/commit/257dfef897db0ece387511d0592076381aaeff2b

    sorry, pushed again because commit message still said lunar

13. glozow renamed this:
    [ci] bump lint task to lunar for git v2.38
    ci: bump lint task to lunar for git v2.38
    on Feb 28, 2023
14. DrahtBot added the label Tests on Feb 28, 2023
15. glozow renamed this:
    ci: bump lint task to lunar for git v2.38
    ci: bump lint task to bookworm for git v2.38
    on Feb 28, 2023
16. 
    achow101 commented at 3:04 PM on February 28, 2023: member

    ACK a984beeca10e3ae1ceb3ea53e4dea778160e7079

17. DrahtBot requested review from maflcko on Feb 28, 2023
18. hebasto approved
19. 
    hebasto commented at 3:07 PM on February 28, 2023: member

    re-ACK a984beeca10e3ae1ceb3ea53e4dea778160e7079

20. maflcko approved
21. DrahtBot requested review from maflcko on Feb 28, 2023
22. fanquake merged this on Feb 28, 2023
23. fanquake closed this on Feb 28, 2023

    ---

24. glozow deleted the branch on Feb 28, 2023
25. sidhujag referenced this in commit ea19e74cb0 on Mar 1, 2023
26. bitcoin locked this on Feb 28, 2024

Contributors

glozowDrahtBothebastomaflckoachow101

Review Requested
achow101maflcko