doc: DummySignInput mention external signer #27180

1. 
   Sjors commented at 9:05 am on March 1, 2023: member

   Followups for #26032. So far nothing major.
2. 
   DrahtBot commented at 9:05 am on March 1, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	ishaanam, S3RK

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. doc: DummySignInput mention external signer 6fc5f4fdb6
4. in src/wallet/wallet.cpp:1651 in 71c0bd2655 outdated

   1647@@ -1648,8 +1648,8 @@ bool DummySignInput(const SigningProvider& provider, CTxIn &tx_in, const CTxOut
   1648     const CScript& scriptPubKey = txout.scriptPubKey;
   1649     SignatureData sigdata;
   1650 
   1651-    // Use max sig if watch only inputs were used or if this particular input is an external input
   1652-    // to ensure a sufficient fee is attained for the requested feerate.
   1653+    // Use max sig if watch only inputs were used, if this particular input is an external input, 
   

   ---

   ---

   

   glozow commented at 10:18 am on March 1, 2023:

   trailing whitespace here
5. Sjors force-pushed on Mar 1, 2023
6. fanquake renamed this:
   26032 followups
   wallet: 26032 followups
   on Mar 1, 2023
7. DrahtBot added the label Wallet on Mar 1, 2023
8. 
   fanquake commented at 2:48 pm on March 7, 2023: member

   Followups for #26032. So far nothing major.

   Are you expecting there to be more? I really only see the one followup comment in #26032.

9. Sjors marked this as ready for review on Mar 7, 2023
10. 
    Sjors commented at 4:50 pm on March 7, 2023: member

    Not really I guess…
11. Sjors renamed this:
    wallet: 26032 followups
    doc: DummySignInput mention external signer
    on Mar 7, 2023
12. 
    fanquake commented at 7:39 pm on March 7, 2023: member

    cc @S3RK @ishaanam @furszy
13. 
    ishaanam commented at 11:03 pm on March 7, 2023: contributor

    ACK 6fc5f4fdb661eb9d42842227501106afcf7111e7
14. 
    S3RK commented at 7:33 am on March 8, 2023: contributor

    ACK 6fc5f4fdb661eb9d42842227501106afcf7111e7

    The comment is correct, CI failure is unrelated

15. fanquake merged this on Mar 8, 2023
16. fanquake closed this on Mar 8, 2023

    ---

17. sidhujag referenced this in commit b0d71056f2 on Mar 8, 2023
18. bitcoin locked this on Mar 7, 2024

Contributors
Sjors DrahtBot glozow fanquake ishaanam S3RK

Labels
Wallet