test: Use self.wait_until over wait_until_helper #27226

1. 
   maflcko commented at 10:33 am on March 8, 2023: member

   wait_until_helper is a “private” helper, not intended to be used directly, because it doesn’t scale the timeout with the timeout factor. Fix this by replacing it with a call to self.wait_until, which does the scaling.
2. test: Use self.wait_until over wait_until_helper faa671591f
3. 
   DrahtBot commented at 10:33 am on March 8, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	theStack
   Concept ACK	fanquake, brunoerg

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on Mar 8, 2023
5. 
   fanquake commented at 10:55 am on March 8, 2023: member

   Concept ACK. Will test under the CI
6. 
   brunoerg commented at 5:41 pm on March 8, 2023: contributor

   Concept ACK
7. 
   fanquake commented at 8:54 pm on March 8, 2023: member

   I’m no-longer seeing #27208 with this change: p2p_ibd_stalling.py | ✓ Passed | 951 s.
8. fanquake requested review from theStack on Mar 8, 2023
9. theStack approved
10. 
    theStack commented at 0:02 am on March 10, 2023: contributor

    Code-review ACK faa671591f9c83ef0fb5afea151a1907c28f024b
11. fanquake merged this on Mar 10, 2023
12. fanquake closed this on Mar 10, 2023

    ---

13. maflcko deleted the branch on Mar 10, 2023
14. sidhujag referenced this in commit 5928a8cf5a on Mar 10, 2023
15. Fabcien referenced this in commit 41da7aa36f on Apr 3, 2023
16. bitcoin locked this on Mar 9, 2024

Contributors
maflcko DrahtBot fanquake brunoerg theStack

Labels
Tests