wallet: 25806 follow-up #27227

1. 
   furszy commented at 1:48 PM on March 8, 2023: member

   Few small findings post-#25806 and extra cleanups, nothing biggie.

2. wallet: do not make two COutputs, use shared_ptr 805f399b17
3. wallet: APS, don't create empty groups

   By moving the "positive-only" flag out of
   the lambda function.

   99034b2b72
4. wallet: OutputGroup, remove unused effective_feerate member a9aa04183c
5. wallet: GroupOutput, remove unneeded "spendable" check

   `AvailableCoins` already filters non-spendable coins.

   8471967d7b
6. wallet: remove unused methods

   CWallet::DummySignTx, OutputGroupTypeMap::find

   8a5583131c
7. 
   DrahtBot commented at 1:48 PM on March 8, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	S3RK, Xekyo, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

8. DrahtBot added the label Wallet on Mar 8, 2023
9. wallet: remove coin control arg from AutomaticCoinSelection

   we only need the "include unsafe" flag, not all what coin
   control stores.

   475c20aa56
10. 
    S3RK commented at 7:54 AM on March 9, 2023: contributor

    Code review ACK 475c20aa568d597c7850c784058596ae26f37496

11. fanquake requested review from josibake on Mar 12, 2023
12. fanquake requested review from murchandamus on Mar 12, 2023
13. fanquake requested review from theStack on Mar 12, 2023
14. 
    murchandamus commented at 9:27 PM on March 15, 2023: contributor

    utACK 475c20aa568d597c7850c784058596ae26f37496

15. DrahtBot removed review request from murchandamus on Mar 15, 2023
16. 
    achow101 commented at 10:59 PM on March 15, 2023: member

    ACK 475c20aa568d597c7850c784058596ae26f37496

17. achow101 merged this on Mar 15, 2023
18. achow101 closed this on Mar 15, 2023

    ---

19. sidhujag referenced this in commit dd7f9c4f68 on Mar 16, 2023
20. sidhujag referenced this in commit f979be15ac on Mar 16, 2023
21. furszy deleted the branch on May 27, 2023
22. bitcoin locked this on May 26, 2024

Contributors

furszyDrahtBotS3RKmurchandamusachow101

Review Requested
theStackjosibake