http: Detect remote disconnect - 2nd attempt #27245

1. 
   fjahr commented at 11:16 pm on March 11, 2023: contributor

   A revival of #19434 but with a few substantial changes.

   The code is valuable but from my understanding, it is offset by the workaround code from #11593. So I have wrapped the code so it’s only used for versions where the workaround does not apply. The original PR removed the workaround code but also led to failures in test/functional/mining_getblocktemplate_longpoll.py so I think this is not an option.

   Since libevent 2.2 is still not out and it’s hard to say when that will happen I am putting this into draft mode.

2. http: Detect remote disconnect

   Co-authored-by: Fabian Jahr <fjahr@protonmail.com>

   d41736beb0
3. 
   DrahtBot commented at 11:16 pm on March 11, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #27909 (http: add evhttp_connection_set_closecb to avoid g_requests hang by Crypt-iQ)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label RPC/REST/ZMQ on Mar 11, 2023
5. 
   fjahr commented at 11:18 pm on March 11, 2023: contributor

   @promag Is my understanding correct or did I miss something from #19434? There was no description on the WIP commit so this is just what I gathered on my own.
6. 
   fanquake commented at 8:13 am on March 12, 2023: member

   Since libevent 2.2 is still not out and it’s hard to say when that will happen

   https://github.com/libevent/libevent/issues/1094

7. 
   fjahr commented at 9:03 am on June 23, 2023: contributor

   Closed in favor of #27909
8. fjahr closed this on Jun 23, 2023

   ---

9. fanquake referenced this in commit db7b5dfcc5 on Oct 4, 2023
10. Frank-GER referenced this in commit b0fea09705 on Oct 13, 2023
11. bitcoin locked this on Jun 22, 2024

Contributors
fjahr DrahtBot fanquake

Labels
RPC/REST/ZMQ