logging: accept "none" as argument for rpc logging #27263

pull pinheadmz wants to merge 1 commits into bitcoin:master from pinheadmz:logging-none changing 2 files +13 −0

pinheadmz commented at 4:00 PM on March 15, 2023: member

The help message for rpc logging includes:

In addition, the following are available as category names with special meanings:
  - "all",  "1" : represent all logging categories.
  - "none", "0" : even if other logging categories are specified, ignore all of them.

However "none" is not currently recognized:

$ bitcoin/src/bitcoin-cli logging "[\"none\"]"
error code: -8
error message:
unknown logging category none

This patch adds the string "none" to match the help instructions.

logging: accept "none" as argument for rpc logging 2b81aa620d
DrahtBot commented at 4:00 PM on March 15, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
jonatack commented at 4:02 PM on March 15, 2023: contributor

I don't think that brings the missing functionality (see #27231, am updating it to just drop the functionality).
fanquake commented at 4:03 PM on March 15, 2023: member

See also #27231.
pinheadmz commented at 4:03 PM on March 15, 2023: member

word! sorry, will track #27231 and review when its ready
pinheadmz closed this on Mar 15, 2023
bitcoin locked this on Mar 14, 2024

Contributors

logging: accept "none" as argument for rpc logging #27263

Reviews