depends: qrencode 4.1.1 #27312

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:qrencode_4_1_1 changing 1 files +4 −3

fanquake commented at 10:35 am on March 23, 2023: member

Upgrade to the latest qrencode, and disable some warnings that cause compile failures with newer compilers (clang-15+).

I haven’t tested this (from a GUI perspective) at all. This is just “good enough” to keep things compiling, and uses some similar work-arounds as we have with other older packages, i.e bdb.

Note that upstream, libqrencode is effectively unmaintained. No code changes for > 2 years. No responses to issues/PRs. Seems like the author has mostly dropped off of GitHub as well.

This fixes part of #27299.

depends: qrencode 4.1.1

Upgrade to the latest qrencode, and disable some warnings that cause
compile failures with newer compilers (clang-15+).

Fixes part of #27299.

eb1c3adf38

fanquake added the label Build system on Mar 23, 2023
fanquake added the label DrahtBot Guix build requested on Mar 23, 2023
DrahtBot commented at 10:35 am on March 23, 2023: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers

ACK TheCharlatan

Concept ACK hebasto, hernanmarino

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
hebasto commented at 11:32 am on March 23, 2023: member

Concept ACK.

Note that upstream, libqrencode is effectively unmaintained. No code changes for > 2 years. No responses to issues/PRs. Seems like the author has mostly dropped off of GitHub as well.

Yeah, this situation is a real concern, unfortunately.

Type	Reviewers
ACK	TheCharlatan
Concept ACK	hebasto, hernanmarino

DrahtBot commented at 0:47 am on March 24, 2023: contributor

Guix builds

File	commit 8acfb1f8e045677b04cf8c4aa790dc6b90d93fa1(master)	commit 635a954e4527775a5c648d5d23e6ddd60ec06805(master and this pull)
SHA256SUMS.part	`b551f0fe973c7695...`	`b2df16ff7564a6fc...`
*-aarch64-linux-gnu-debug.tar.gz	`bc4fdeee751a3e70...`	`2371dee1ad0f6929...`
*-aarch64-linux-gnu.tar.gz	`905ba02b9865e4b4...`	`604633a55d91eb24...`
*-arm-linux-gnueabihf-debug.tar.gz	`a0035eaebff1c3ab...`	`f1818c5577a7570b...`
*-arm-linux-gnueabihf.tar.gz	`2a54c728a5684a07...`	`1e8810358d429fe6...`
*-powerpc64-linux-gnu-debug.tar.gz	`e68aeb78dbc76930...`	`ace79311b3751ebb...`
*-powerpc64-linux-gnu.tar.gz	`491be59d7bcca27b...`	`3770587745f5e07b...`
*-powerpc64le-linux-gnu-debug.tar.gz	`0b6b6ac221be18eb...`	`ed503e2e021c66ef...`
*-powerpc64le-linux-gnu.tar.gz	`7449ab3e65d7e525...`	`30b461e2473b23a5...`
*-riscv64-linux-gnu-debug.tar.gz	`282da8415d4cd8df...`	`cd3413a659ca7a4c...`
*-riscv64-linux-gnu.tar.gz	`c7b92f98459171ae...`	`485a14c6dfc3d780...`
*-x86_64-linux-gnu-debug.tar.gz	`6a99deddeb8bba62...`	`b2ab0bea55e63e39...`
*-x86_64-linux-gnu.tar.gz	`8701d55d016e7fe2...`	`29f6bad32c114a41...`
*.tar.gz	`4615a30fb127dda6...`	`e060855da424a324...`
guix_build.log	`f1eb1f24be141e20...`	`40aae94c0d400c64...`
guix_build.log.diff		`525f0077fa08e97c...`

DrahtBot removed the label DrahtBot Guix build requested on Mar 24, 2023
maflcko added the label GUI on Mar 24, 2023
TheCharlatan approved
TheCharlatan commented at 8:59 pm on March 24, 2023: contributor

Code review ACK eb1c3adf38cb71c3e6f298a61871738c4919b4a1

I checked that the additional cflags indeed suppress errors when building with clang-15. Also went though the changed configure flags and did a quick sanity check in the gui.
hernanmarino approved
hernanmarino commented at 11:16 pm on March 26, 2023: contributor

tested ACK, both compiling and QR generation .
fanquake merged this on Mar 27, 2023
fanquake closed this on Mar 27, 2023
fanquake deleted the branch on Mar 27, 2023
prusnak commented at 11:35 am on March 27, 2023: contributor

There is this library which is maintained and available in multiple programming languages (C and C++ are two of them): https://github.com/nayuki/QR-Code-generator
hernanmarino commented at 12:44 pm on March 27, 2023: contributor

There is this library which is maintained and available in multiple programming languages (C and C++ are two of them): https://github.com/nayuki/QR-Code-generator

I can take a look and attempt migrating to it, unless you e want to work on it yourself, @prusnak
prusnak commented at 12:49 pm on March 27, 2023: contributor

I can take a look and attempt migrating to it, unless you e want to work on it yourself, @prusnak

Feel free to explore that area.
sidhujag referenced this in commit 26134c90aa on Mar 27, 2023
achow101 referenced this in commit a3eea2a27d on Apr 11, 2023
sidhujag referenced this in commit c251adfeba on Apr 11, 2023
bitcoin locked this on Mar 26, 2024

Contributors
fanquake DrahtBot hebasto TheCharlatan hernanmarino prusnak

Labels
GUI Build system

depends: qrencode 4.1.1 #27312

Reviews

Guix builds