Add coding style document #2735

The document will need to be edited slightly for Bitcoin specifics, but its a starting point!

Does this include everything from doc/coding.md? Which I assume it's trying to replace.

Leaning towards general NAK. This is imposing one coder's view of how code should be written, when we already have another coding style doc that originated from coders with heavy bitcoin.git contributions.

@fanquake This is not supposed to be a replacement for doc/coding.md

In general, don't overburden anywhere with rules. The main GUIDELINES (not rules) are: make new code look like existing code, and follow project developer consensus on any style changes.

While rules/tips to avoid shooting yourself in the foot can be welcome and even necessary in language such as C++, I don't like how this starts off with a screenful of rules about formatting. Just use the same convention as the code you're editing. As for the rest, there would have to be developer consensus on a rule by rule basis. It looks like this came from some other project? (If so; which?)

I believe Gavin or Mike H or similar pointing to Google's C++ coding conventions as some good rules to follow. They seemed pretty sane, also.

tl; dr

closing

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/18e6e3ed07744e2fd0ac077e210068f5ee8a8f26 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.