depends: add NO_HARDEN= option #27406

1. 
   fanquake commented at 1:18 pm on April 3, 2023: member

   Add an option that when passed, will disable hardening options, and pass --disable-hardening through to configure. Due to the way we link libssp for Windows builds, they now fail (after #27118), if building with depends, and configuring with --disable-hardening (Windows is the odd build out here). See: #27118 (comment).

   This change would add a depends option such that, if someone wants to build with depends, for Windows, without hardening, they can do so. This may also be useful when building for debugging.

2. 
   DrahtBot commented at 1:18 pm on April 3, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto
   Concept ACK	theuni

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #24123 (build: Pointer Authentication and Branch Target Identification for aarch64 Linux (Guix) by fanquake)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Build system on Apr 3, 2023
4. 
   fanquake commented at 1:18 pm on April 3, 2023: member

   cc @hebasto @TheCharlatan
5. in depends/README.md:126 in 24ef4bb6c2 outdated

   122@@ -123,6 +123,7 @@ The following can be set when running make: `make FOO=bar`
   123   resides in the `depends` directory, and the log file is printed out automatically in case
   124   of build error. After successful build log files are moved along with package archives
   125 - `LTO`: Use LTO when building packages.
   126+- `NO_HARDEN=1`: Don't use hardneing options when building packages
   

   ---

   ---

   

   theuni commented at 6:34 pm on April 3, 2023:

   Nit: spelling

   ---

   

   fanquake commented at 9:08 am on April 4, 2023:

   Thanks, fixed.
6. 
   theuni commented at 6:35 pm on April 3, 2023: member

   ACK modulo spelling nit.
7. hebasto approved
8. 
   hebasto commented at 8:48 am on April 4, 2023: member

   ACK 24ef4bb6c2266e157008cbd2c394f9f83c7b5816, tested on Ubuntu 22.04.

   Happy to re-ACK after fixing a typo :)

9. depends: add NO_HARDEN option

   Add an option that when passed, will disable hardening options, and
   pass `--disable-hardening` through to configure. Due to the way
   we link libssp for Windows builds, they now fail (after #27118),
   if building with depends, and configuring with --disable-hardening.
   See:
   https://github.com/bitcoin/bitcoin/pull/27118#issuecomment-1492606272.
   
   This change would add a depends opiton such that, if someone wants to
   build with, for windows, without hardening, they can do so. This may
   also be useful when building for debugging.

   436df1e826
10. fanquake force-pushed on Apr 4, 2023
11. 
    fanquake commented at 9:08 am on April 4, 2023: member

    Pushed to fix the typo.
12. hebasto approved
13. 
    hebasto commented at 9:45 am on April 4, 2023: member

    re-ACK 436df1e826cae036caed3e983715a4ed4e441321
14. fanquake merged this on Apr 5, 2023
15. fanquake closed this on Apr 5, 2023

    ---

16. fanquake deleted the branch on Apr 5, 2023
17. sidhujag referenced this in commit aa7de3df60 on Apr 5, 2023
18. 
    theuni commented at 5:45 pm on April 5, 2023: member

    Post-merge ACK 436df1e826cae036caed3e983715a4ed4e441321
19. bitcoin locked this on Apr 4, 2024

Contributors
fanquake DrahtBot theuni hebasto

Labels
Build system