build: remove ancient unused define #27420

pull theuni wants to merge 1 commits into bitcoin:master from theuni:remove-win-define changing 1 files +1 −1
  1. theuni commented at 5:17 PM on April 4, 2023: member

    The generic define was removed in upstream miniupnpc in 2014.

    Noticed while reviewing hebasto's new CMake buildsystem: https://github.com/hebasto/bitcoin/pull/12#discussion_r1156267350.

  2. build: remove ancient unused define
    The generic define was removed in upstream miniupnpc in 2014:
    https://github.com/miniupnp/miniupnp/commit/f6774e33169b3101c3a242984510c9b6da033e26
    
    Noticed while reviewing hebasto's new CMake buildsystem:
    https://github.com/hebasto/bitcoin/pull/12#discussion_r1156267350
    9fbc5fcd28
  3. DrahtBot commented at 5:17 PM on April 4, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto, RandyMcMillan, TheCharlatan
    Concept ACK Ayush170-Future

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Build system on Apr 4, 2023
  5. hebasto approved
  6. hebasto commented at 5:32 PM on April 4, 2023: member

    ACK 9fbc5fcd28eeefd3ad1932a2d94e5558deeb16d7

    Our minimum miniupnpc version is v2.1, while an upstream change was introduced in v1.9.

  7. RandyMcMillan commented at 6:47 PM on April 4, 2023: contributor

    utACK 9fbc5fc

  8. Ayush170-Future approved
  9. Ayush170-Future commented at 7:39 PM on April 4, 2023: contributor

    ACK

  10. TheCharlatan approved
  11. TheCharlatan commented at 8:38 PM on April 4, 2023: contributor

    ACK 9fbc5fcd28eeefd3ad1932a2d94e5558deeb16d7

  12. fanquake merged this on Apr 5, 2023
  13. fanquake closed this on Apr 5, 2023

  14. sidhujag referenced this in commit eb4bfad4b2 on Apr 5, 2023
  15. bitcoin locked this on Apr 4, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-18 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me