The generic define was removed in upstream miniupnpc in 2014.
Noticed while reviewing hebasto's new CMake buildsystem: https://github.com/hebasto/bitcoin/pull/12#discussion_r1156267350.
build: remove ancient unused define #27420
pull theuni wants to merge 1 commits into bitcoin:master from theuni:remove-win-define changing 1 files +1 −1-
theuni commented at 5:17 PM on April 4, 2023: member
-
9fbc5fcd28
build: remove ancient unused define
The generic define was removed in upstream miniupnpc in 2014: https://github.com/miniupnp/miniupnp/commit/f6774e33169b3101c3a242984510c9b6da033e26 Noticed while reviewing hebasto's new CMake buildsystem: https://github.com/hebasto/bitcoin/pull/12#discussion_r1156267350
-
DrahtBot commented at 5:17 PM on April 4, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK hebasto, RandyMcMillan, TheCharlatan Concept ACK Ayush170-Future If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Build system on Apr 4, 2023
- hebasto approved
-
-
RandyMcMillan commented at 6:47 PM on April 4, 2023: contributor
utACK 9fbc5fc
- Ayush170-Future approved
-
Ayush170-Future commented at 7:39 PM on April 4, 2023: contributor
ACK
- TheCharlatan approved
-
TheCharlatan commented at 8:38 PM on April 4, 2023: contributor
ACK 9fbc5fcd28eeefd3ad1932a2d94e5558deeb16d7
- fanquake merged this on Apr 5, 2023
- fanquake closed this on Apr 5, 2023
- sidhujag referenced this in commit eb4bfad4b2 on Apr 5, 2023
- bitcoin locked this on Apr 4, 2024
Labels