contrib: followups to #27358 (verify-binaries) #27440

1. 
   fanquake commented at 10:50 am on April 9, 2023: member

   Followup to #27358, fixing up the example command docs and other requests. See #27358 (comment).
2. contrib: move verify scripts to verify-binaries 663a89cfed
3. fanquake requested review from Sjors on Apr 9, 2023
4. fanquake requested review from theuni on Apr 9, 2023
5. fanquake requested review from josibake on Apr 9, 2023
6. 
   DrahtBot commented at 10:50 am on April 9, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	josibake, theuni, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

7. DrahtBot added the label Scripts and tools on Apr 9, 2023
8. in contrib/verify-binaries/README.md:46 in d8c97fbfd9 outdated

   41@@ -42,47 +42,47 @@ See the `Config` object for various options.
   42 
   43 Validate releases with default settings:
   44 ```sh
   45-./contrib/verifybinaries/verify.py pub 22.0
   46-./contrib/verifybinaries/verify.py pub 22.0-rc2
   47+./contrib/verify-binaries/verify.py pub 22.0
   48+./contrib/verify-binaries/verify.py pub 22.0-rc2
   

   ---

   ---

   

   josibake commented at 11:04 am on April 9, 2023:

   not introduced in this PR, but this is still broken (22.0-rc2)

   0[ERROR] failed to download aarch64-linux-gnu/bitcoin-22.0rc2-aarch64-linux-gnu.tar.gz
   1wget output:
   2  aarch64-linux-gnu/bitcoin-22.0rc2-aarch64-linux-gnu.tar.gz: No such file or directory
   

   ---

   

   fanquake commented at 11:09 am on April 9, 2023:

   Looks like this is due to an extra level of nesting in the bitcoincore.org directory structure, which is only present for the 22.0 rc2 bins. Just changed this to rc3, which doesn’t have the issue.

   ---

   

   josibake commented at 11:20 am on April 9, 2023:

   ah, so the script is dependent on the folder structure at bitcoincore.org.. @Sjors mentioned maybe adding a domain argument, but that won’t work unless all domains use the same folder structures.

   ---

   

   theuni commented at 4:04 pm on April 10, 2023:

   Yeah, I think this is the crux of the thing. Agree that we need a domain argument for this script to be generic enough to be useful. So I propose that we (as yet another follow-up):

   • Document the current assumed remote dir structure and call it the standard*.
   • Hook up a domain option that’s intended to work with above well-documented standard.

   This would allow for a crude federated model of pulling that suits the multisig model well, so I think it’s a good way forward for us.

   * Obviously we could instead bikeshed a new structure and hardcode/deprecate prior ones.

   ---

   

   josibake commented at 8:40 pm on April 10, 2023:

   Anybody interested in taking #27440 (comment) ? :)

   I can take a crack at it, I already started working on a proof of concept for searching for the file name regardless of the folder structure

9. contrib: fixup verifybinaries example docs

   Followup to #27358, fixing up the example command docs.

   e2e5683afe
10. contrib: minor doc improvements in verify-binaries ad841608d4
11. fanquake force-pushed on Apr 9, 2023
12. 
    josibake commented at 11:16 am on April 9, 2023: member

    ACK https://github.com/bitcoin/bitcoin/pull/27440/commits/ad841608d4edf6151b60e483793f60ba9f03cdbf

    looks good, ran through the steps in the docs, grepped to make sure there are no references to verifybinaries

13. theuni approved
14. 
    theuni commented at 4:33 pm on April 10, 2023: member

    ACK ad841608d4edf6151b60e483793f60ba9f03cdbf. Thanks for doing these.

    Anybody interested in taking #27440 (review) ? :)

15. 
    achow101 commented at 1:18 am on April 11, 2023: member

    ACK ad841608d4edf6151b60e483793f60ba9f03cdbf
16. achow101 merged this on Apr 11, 2023
17. achow101 closed this on Apr 11, 2023

    ---

18. sidhujag referenced this in commit e4cb1a7d09 on Apr 11, 2023
19. fanquake deleted the branch on Apr 11, 2023
20. bitcoin locked this on Apr 10, 2024

Contributors
fanquake DrahtBot josibake theuni achow101

Review Requested
Sjors

Labels
Scripts and tools