verify-commits: error and exit cleanly when git is too old. #27461

1. 
   theuni commented at 9:26 PM on April 13, 2023: member

   Requested by fanquake. Rather than failing with a cryptic error with older git, fail gracefully and mention why.

   The new option semantics are explained here.

   Note: my local git versions are currently too old to test the new functionality, so I've only verified the failure case.

2. verify-commits: error and exit cleanly when git is too old. 1fefcf27ed
3. 
   DrahtBot commented at 9:26 PM on April 13, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	josibake, achow101
   Concept ACK	glozow

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. fanquake added this to the milestone 25.0 on Apr 14, 2023
5. 
   glozow commented at 9:47 AM on April 14, 2023: member

   concept ACK

6. 
   josibake commented at 11:05 AM on April 14, 2023: member

   ACK https://github.com/bitcoin/bitcoin/pull/27461/commits/1fefcf27edcac7ebb87c1d3c68bcd9870e3ae78a

   was able to verify the failure case (v2.34) and the happy case (v2.4)

7. 
   achow101 commented at 1:26 PM on April 14, 2023: member

   ACK 1fefcf27edcac7ebb87c1d3c68bcd9870e3ae78a

8. achow101 merged this on Apr 14, 2023
9. achow101 closed this on Apr 14, 2023

   ---

10. sidhujag referenced this in commit 9ba71993e5 on Apr 14, 2023
11. bitcoin locked this on Apr 13, 2024

Milestone
25.0