test: fix bumpfee 'spend_one_input' occasional failure #27471

pull furszy wants to merge 1 commits into bitcoin:master from furszy:2023_fix_test_bumpfee_sporadic_failure changing 1 files +9 −2

furszy commented at 2:23 AM on April 16, 2023: member

CI test failure, in master: https://cirrus-ci.com/task/5975232842825728. In #27469 https://cirrus-ci.com/task/6452468402356224

Most of the subtests in wallet_bumpfee.py expect to find spendable UTXOs of 0.001 btc in the rbf wallet. They use the spend_one_input() method which fails if none of them exist.

The sporadic failure comes from the recently added test_feerate_checks_replaced_outputs subtest that can spend all them. Leaving the next subtests with no 0.001 UTXOs to spend.

To solve it, this PR moves the recently added case into a "context independent subtests" section. Which is placed at the end to not affect other cases.

test: fix bumpfee 'spend_one_input' occasional failure

Most of the subtests in wallet_bumpfee.py expect to
find spendable UTXOs of 0.001 btc in the rbf wallet
(they use the 'spend_one_input()' method that tries
to spend one of them and if it doesn't find any, it
throws an exception).

The sporadic failure comes from the recently added
'test_feerate_checks_replaced_outputs' subtest that
can spend all them. Leaving the next subtests with
no 0.001 UTXOs to spend.

To solve it, this PR moves the recently added case
into a "context independent subtests" section.
Which is placed at the end to not affect other cases.

e07dd5fff9

DrahtBot commented at 2:23 AM on April 16, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK achow101, pablomartin4btc

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Apr 16, 2023
fanquake requested review from murchandamus on Apr 16, 2023
fanquake requested review from glozow on Apr 16, 2023
fanquake requested review from achow101 on Apr 16, 2023
achow101 added this to the milestone 25.0 on Apr 17, 2023
achow101 commented at 1:48 PM on April 17, 2023: member

ACK e07dd5fff9eb64d7615ab515b351e296c00b1861
DrahtBot removed review request from achow101 on Apr 17, 2023
jonatack commented at 2:13 PM on April 17, 2023: contributor

Another failure just now. https://cirrus-ci.com/task/5307259153022976
pablomartin4btc commented at 2:24 PM on April 17, 2023: member

ACK https://github.com/bitcoin/bitcoin/commit/e07dd5fff9eb64d7615ab515b351e296c00b1861.
fanquake merged this on Apr 17, 2023
fanquake closed this on Apr 17, 2023
sidhujag referenced this in commit 2a7efd46df on Apr 17, 2023
furszy deleted the branch on May 27, 2023
bitcoin locked this on May 26, 2024