depends: no-longer nuke libc++abi.so* in native

fanquake commented at 2:29 pm on April 19, 2023: member

We weren’t copying it over in any case.

DrahtBot commented at 2:29 pm on April 19, 2023: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto, theuni

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#21778 (build: LLVM 15 & LLD based macOS toolchain by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot added the label CI failed on Apr 19, 2023

fanquake force-pushed on Apr 21, 2023

depends: no-longer nuke libc++abi.so* in native_clang package

We weren't copying it over in any case.

9ae854da19

fanquake renamed this:
~~[WIP] build: use LLVM/Clang 14 for Darwin builds~~
depends: no-longer nuke libc++abi.so* in native_clang package
on May 11, 2023

fanquake force-pushed on May 11, 2023

fanquake marked this as ready for review on May 11, 2023

fanquake requested review from theuni on May 11, 2023

fanquake requested review from TheCharlatan on May 11, 2023

fanquake commented at 1:18 pm on May 11, 2023: member

Guix Build:

 0f05e6ab973d999e7fd8445c580bf919a6c7ffcdabbfac30cefaa8a81c1c8d804  guix-build-9ae854da193f/output/aarch64-linux-gnu/SHA256SUMS.part
 14294c97d12f0c29ad9d3211fb455ac2a2b9933c13efa061b1753917a11dbbaf5  guix-build-9ae854da193f/output/aarch64-linux-gnu/bitcoin-9ae854da193f-aarch64-linux-gnu-debug.tar.gz
 2cf80ca7545331b69ca2c1496eab26122fcf7499e6674e9cabf168b3cfe3d10d8  guix-build-9ae854da193f/output/aarch64-linux-gnu/bitcoin-9ae854da193f-aarch64-linux-gnu.tar.gz
 3816d7fc4bbc6deba33701f176588280fa621ccdca74b08ea691b36ccfeac25ab  guix-build-9ae854da193f/output/arm-linux-gnueabihf/SHA256SUMS.part
 46f0a92c16cab92fb4e329cb2151b72e3f36f474b7d655ba341018c686cb84e50  guix-build-9ae854da193f/output/arm-linux-gnueabihf/bitcoin-9ae854da193f-arm-linux-gnueabihf-debug.tar.gz
 52d3e3a2c7f1773f0bae202d91597cb4ae4e0a6fb1022e44873416e52274648cf  guix-build-9ae854da193f/output/arm-linux-gnueabihf/bitcoin-9ae854da193f-arm-linux-gnueabihf.tar.gz
 662c1107f10dc3e392f6899a031a7a266c8408dc20570b5fad2afb5f268ca11ed  guix-build-9ae854da193f/output/arm64-apple-darwin/SHA256SUMS.part
 7e087a23ec35fa26b2dd7aa669ea728ba7f3312d3fff4335245a3da11f935c3d2  guix-build-9ae854da193f/output/arm64-apple-darwin/bitcoin-9ae854da193f-arm64-apple-darwin-unsigned.dmg
 85fceb74a6f87295a2ca4b8c601a8b1a6971d80f13aeb7d7b7456afb9f13dfaf0  guix-build-9ae854da193f/output/arm64-apple-darwin/bitcoin-9ae854da193f-arm64-apple-darwin-unsigned.tar.gz
 98cc67dd7133f15899d1098d2f51a8bf26f9314c26ed08349269cd0bc36848ab9  guix-build-9ae854da193f/output/arm64-apple-darwin/bitcoin-9ae854da193f-arm64-apple-darwin.tar.gz
1066ef78cc463538602b9e071918a2d7cce03b55911022a1a3024e1b5e3e4005be  guix-build-9ae854da193f/output/dist-archive/bitcoin-9ae854da193f.tar.gz
1116880492021216696af025e0203013c5fd22ff0331e38de4760847b398608e4a  guix-build-9ae854da193f/output/powerpc64-linux-gnu/SHA256SUMS.part
1224f1ea806c53fbe9a20afbbd8ca6a510a8d7ed05ba918abad374e95e5672efb1  guix-build-9ae854da193f/output/powerpc64-linux-gnu/bitcoin-9ae854da193f-powerpc64-linux-gnu-debug.tar.gz
13dbca60ededc9a0cd9a470d86e3113da56e711a3a1780cb438d95f932b4b8c503  guix-build-9ae854da193f/output/powerpc64-linux-gnu/bitcoin-9ae854da193f-powerpc64-linux-gnu.tar.gz
141a5777107eb4db3a04bd40403a57b569166b63c21da6704a05ff3fe6c7916c28  guix-build-9ae854da193f/output/powerpc64le-linux-gnu/SHA256SUMS.part
1501d9570be3cdec744573d396a63b5abccfcdc23610f74330d0842b0ebaa0840b  guix-build-9ae854da193f/output/powerpc64le-linux-gnu/bitcoin-9ae854da193f-powerpc64le-linux-gnu-debug.tar.gz
16cd2b3a9ac31924492d318b1331afb5d14d819f90f6482ecbb2de542e2bb2c444  guix-build-9ae854da193f/output/powerpc64le-linux-gnu/bitcoin-9ae854da193f-powerpc64le-linux-gnu.tar.gz
17df48964960dd06085559c7b7c2a26198487c3db2939b88600be9a78ca6328664  guix-build-9ae854da193f/output/riscv64-linux-gnu/SHA256SUMS.part
1844a7a6e85065839de2d9a66009aa89503b8917af79ba9ea7da8d819b90b4163b  guix-build-9ae854da193f/output/riscv64-linux-gnu/bitcoin-9ae854da193f-riscv64-linux-gnu-debug.tar.gz
19e148d4d696a2837004f21caaad80d06abef3af93cc1fce7fec0a6efe2efbdc9d  guix-build-9ae854da193f/output/riscv64-linux-gnu/bitcoin-9ae854da193f-riscv64-linux-gnu.tar.gz
20157b27c94f6f0d4e975ba14919f23bc93901bfb8d6bd59914ab95856879c943a  guix-build-9ae854da193f/output/x86_64-apple-darwin/SHA256SUMS.part
21ca0e7c004d057c2631cf986510782be490aadfbfa3b66292f9602db58f6fdb99  guix-build-9ae854da193f/output/x86_64-apple-darwin/bitcoin-9ae854da193f-x86_64-apple-darwin-unsigned.dmg
2208e96e9795d249a0af373723d950c5a0fab57c9bf1c843faf1a164821d844350  guix-build-9ae854da193f/output/x86_64-apple-darwin/bitcoin-9ae854da193f-x86_64-apple-darwin-unsigned.tar.gz
23926c4fa7a44cb73075d97d2c691211620e1a5cc213cebbc77011b635a3559f09  guix-build-9ae854da193f/output/x86_64-apple-darwin/bitcoin-9ae854da193f-x86_64-apple-darwin.tar.gz
24bd7e20b29c3c420e2b3203be9f7fba39fcc7fc273d95d2c8258af9a33c21a851  guix-build-9ae854da193f/output/x86_64-linux-gnu/SHA256SUMS.part
25bda9d652f853e37d9da399f4388bc4db8061a56d3d1ef10282c586c3ad48d464  guix-build-9ae854da193f/output/x86_64-linux-gnu/bitcoin-9ae854da193f-x86_64-linux-gnu-debug.tar.gz
2691cdf82483a67fe04ac898befe3323ca106ac09c4bbb466cf869455c71c3f62b  guix-build-9ae854da193f/output/x86_64-linux-gnu/bitcoin-9ae854da193f-x86_64-linux-gnu.tar.gz
2762405aa32e481e3d9ed9944e479a709bb104f79a9bddcbbaf63794dc42a75722  guix-build-9ae854da193f/output/x86_64-w64-mingw32/SHA256SUMS.part
28ebeb96b594d617a3fa2ca050df0c909fc38d00d6702be60750b787f27c4563a8  guix-build-9ae854da193f/output/x86_64-w64-mingw32/bitcoin-9ae854da193f-win64-debug.zip
29d3281a1b5e310262411d3d65d8655581409dc643a21570ae18a981889885a045  guix-build-9ae854da193f/output/x86_64-w64-mingw32/bitcoin-9ae854da193f-win64-setup-unsigned.exe
30fc7481ee674bff404762e643bdc1ce0269927bd26350d9322eab15b2c384274c  guix-build-9ae854da193f/output/x86_64-w64-mingw32/bitcoin-9ae854da193f-win64-unsigned.tar.gz
31fb9462e9ab86eff2210b831e34d339818d3fe7b19c78bc507802e665da0d60f5  guix-build-9ae854da193f/output/x86_64-w64-mingw32/bitcoin-9ae854da193f-win64.zip

hebasto commented at 1:52 pm on May 11, 2023: member

ACK 9ae854da193f3c4bda38a75e96f9b989b289baab

Actually, this PR introduces no changes to the native_clang package at all:

 0$ git fetch origin pull/27493/head
 1$ git checkout FETCH_HEAD
 2$ make -C depends clean-all
 3$ make -C depends native_clang HOST=x86_64-apple-darwin
 4$ cat depends/built/x86_64-apple-darwin/native_clang/native_clang-10.0.1-*.tar.gz.hash
 5300b13fa3db495f3ad33f729a2fa2688e84d928a17ef8f4eb1164e062ad924c6  native_clang-10.0.1-a7086a951bd.tar.gz
 6$ git checkout HEAD~1
 7$ make -C depends clean-all
 8$ make -C depends native_clang HOST=x86_64-apple-darwin
 9$ cat depends/built/x86_64-apple-darwin/native_clang/native_clang-10.0.1-*.tar.gz.hash 
10300b13fa3db495f3ad33f729a2fa2688e84d928a17ef8f4eb1164e062ad924c6  native_clang-10.0.1-35214e746a1.tar.gz

UPD. Guix build:

062c1107f10dc3e392f6899a031a7a266c8408dc20570b5fad2afb5f268ca11ed  guix-build-9ae854da193f/output/arm64-apple-darwin/SHA256SUMS.part
1e087a23ec35fa26b2dd7aa669ea728ba7f3312d3fff4335245a3da11f935c3d2  guix-build-9ae854da193f/output/arm64-apple-darwin/bitcoin-9ae854da193f-arm64-apple-darwin-unsigned.dmg
25fceb74a6f87295a2ca4b8c601a8b1a6971d80f13aeb7d7b7456afb9f13dfaf0  guix-build-9ae854da193f/output/arm64-apple-darwin/bitcoin-9ae854da193f-arm64-apple-darwin-unsigned.tar.gz
38cc67dd7133f15899d1098d2f51a8bf26f9314c26ed08349269cd0bc36848ab9  guix-build-9ae854da193f/output/arm64-apple-darwin/bitcoin-9ae854da193f-arm64-apple-darwin.tar.gz
466ef78cc463538602b9e071918a2d7cce03b55911022a1a3024e1b5e3e4005be  guix-build-9ae854da193f/output/dist-archive/bitcoin-9ae854da193f.tar.gz
5157b27c94f6f0d4e975ba14919f23bc93901bfb8d6bd59914ab95856879c943a  guix-build-9ae854da193f/output/x86_64-apple-darwin/SHA256SUMS.part
6ca0e7c004d057c2631cf986510782be490aadfbfa3b66292f9602db58f6fdb99  guix-build-9ae854da193f/output/x86_64-apple-darwin/bitcoin-9ae854da193f-x86_64-apple-darwin-unsigned.dmg
708e96e9795d249a0af373723d950c5a0fab57c9bf1c843faf1a164821d844350  guix-build-9ae854da193f/output/x86_64-apple-darwin/bitcoin-9ae854da193f-x86_64-apple-darwin-unsigned.tar.gz
8926c4fa7a44cb73075d97d2c691211620e1a5cc213cebbc77011b635a3559f09  guix-build-9ae854da193f/output/x86_64-apple-darwin/bitcoin-9ae854da193f-x86_64-apple-darwin.tar.gz

DrahtBot removed the label CI failed on May 11, 2023

DrahtBot added the label Build system on May 11, 2023

theuni approved

theuni commented at 5:12 pm on May 12, 2023: member

Sure. utACK no-op 9ae854da193f3c4bda38a75e96f9b989b289baab.

fanquake merged this on May 14, 2023

fanquake closed this on May 14, 2023

fanquake deleted the branch on May 14, 2023

sidhujag referenced this in commit 2582f09b6b on May 15, 2023

bitcoin locked this on May 13, 2024

depends: no-longer nuke libc++abi.so* in native_clang package #27493

Reviews

Conflicts