These routines look fancy, but do nothing more than converting between byte objects of length 32 to/from integers in little endian byte order and can be replaced by simple one-liners, using the int.{from,to}_bytes methods (available since Python 3.2).
test: simplify uint256 (de)serialization routines #27516
pull theStack wants to merge 1 commits into bitcoin:master from theStack:test-simplify_uint256_serialization_routines changing 1 files +7 −15-
theStack commented at 1:01 AM on April 23, 2023: contributor
-
96bf0bca4a
test: simplify uint256 (de)serialization routines
These routines look fancy, but do nothing more than converting between byte objects of length 32 to/from integers in little endian byte order and can be replaced by simple one-liners, using the int.{from,to}_bytes methods (available since Python 3.2). -
DrahtBot commented at 1:01 AM on April 23, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK MarcoFalke, brunoerg If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Apr 23, 2023
-
maflcko commented at 8:59 AM on April 24, 2023: member
lgtm ACK 96bf0bca4a0e3aa0b7c07d8c225861e72f970fa9
- brunoerg approved
-
brunoerg commented at 11:56 AM on April 24, 2023: contributor
crACK 96bf0bca4a0e3aa0b7c07d8c225861e72f970fa9
- fanquake merged this on Apr 25, 2023
- fanquake closed this on Apr 25, 2023
- sidhujag referenced this in commit be84e4b355 on Apr 28, 2023
- theStack deleted the branch on Apr 30, 2023
- bitcoin locked this on Apr 29, 2024
