http, rest: improving segfault bugfix logic - optimisation #27519

pull pablomartin4btc wants to merge 1 commits into bitcoin:master from pablomartin4btc:http-rest-segfault-bugfix-optimisation changing 4 files +85 −51
  1. pablomartin4btc commented at 1:38 PM on April 23, 2023: member

    As first commit of #27253 was already merged into 25.0 release branch (#27468), this PR represents the second commit of the original PR #27253, where the fix was split in 2 commits for clarity and reviewers benefit(1 with the fix and 1 with an enhancement of it).

    Please for reference have a quick look at PRs mentioned above and check the description of this commit for the intention of this PR.

  2. http, rest: move segfault bugfix logic improvement
    Non-functional optimisation: moving the logic up
    in the stack, specifically into the constructor
    of the HTTPRequest object, this way we catch the invalid uri earlier,
    removing the exception handling from the rest enpoints as we catch
    the exception raised from the constructor within the request
    call back function where we return an http bad request to consumers.
    37e3f91f3e
  3. DrahtBot commented at 1:38 PM on April 23, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. fanquake commented at 1:40 PM on April 23, 2023: member

    Why is this a new PR? You just need to rebase #27253.

  5. pablomartin4btc commented at 1:45 PM on April 23, 2023: member

    Why is this a new PR? You just need to rebase #27253.

    Ok, I was going close that one for clarity, but it's ok, I rebased #27253 already just waiting for the tests to finish running, label "needs rebase" wasn't removed automatically.

    Happy to close this one.

  6. pablomartin4btc closed this on Apr 23, 2023

  7. bitcoin locked this on Apr 22, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me