Drop support for g++-8? #27537

1. 
   maflcko commented at 7:57 AM on April 27, 2023: member

   I am wondering when we can drop support for g++-8. All supported operating systems, except for CentOS Stream 8 offer a greater version:

   • Ubuntu Focal: gcc 9 (https://packages.ubuntu.com/focal/gcc)
   • Debian Bullseye: gcc 10 (https://packages.debian.org/bullseye/gcc)
   • CentOS 8 Stream: gcc 8, with EOL of " May 31st, 2024 " (https://www.centos.org/centos-stream/)

   The rationale for dropping it would be that there are currently occasional compile failures with perfectly valid C++-17 code, for example:

   • error: call to non-‘constexpr’ function ‘void __assert_fail(const char*, const char*, unsigned int, const char*)’ assert(false); (https://godbolt.org/z/bxaMnfcsa)
2. maflcko added this to the milestone 27.0 on Apr 27, 2023
3. 
   maflcko commented at 8:03 AM on April 27, 2023: member

   Added 27.0 for now, which should be uncontroversial.

4. 
   fanquake commented at 9:05 AM on April 27, 2023: member

   Concept ACK. I think we could even drop 8 for 26.x.

5. 
   hebasto commented at 9:11 AM on April 27, 2023: member

   Concept ACK.

6. 
   emc99 commented at 5:47 PM on April 28, 2023: none

   What does ACK mean?

7. 
   jonatack commented at 5:48 PM on April 28, 2023: contributor

   What does ACK mean?

   https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core#terminology

8. 
   ferzan98 commented at 10:11 AM on May 10, 2023: none

   ack means short for acknowledgment

9. 
   maflcko commented at 1:08 PM on May 15, 2023: member

   Looks like one bug I presumed to be fixed in g++9 is affecting all versions of g++, even 13.1. Maybe someone should report that upstream, because it is valid C++ code and works in clang: https://godbolt.org/z/fM39z38nc

10. 
    maflcko commented at 7:49 AM on May 16, 2023: member

    Closing for now. Let's continue discussion in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109871 and #https://github.com/bitcoin/bitcoin/pull/27662

11. maflcko closed this on May 16, 2023

    ---

12. 
    maflcko commented at 1:08 PM on May 17, 2023: member

    (The gcc bug was just fixed in 13.2)

13. fanquake referenced this in commit edd6d8395f on May 19, 2023
14. bitcoin locked this on May 16, 2024

Milestone
27.0