test: Remove modinv python util helper function #27538

pull fjahr wants to merge 1 commits into bitcoin:master from fjahr:pr27483 changing 3 files +4 −28

fjahr commented at 12:06 PM on April 28, 2023: contributor

Since #27483 was merged the modinv() body is just one line calling pythons own implementation of pow(). We can just remove the function as it doesn't seem to add any value. Additionally the comment in the function is now outdated and the test is only testing two ways of doing modular inverse but both using python's pow() function.
DrahtBot commented at 12:06 PM on April 28, 2023: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK theStack

Concept ACK sipa, kevkevinpal

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #27507 (lint: stop ignoring LIEF imports by fanquake)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot added the label Tests on Apr 28, 2023
sipa commented at 12:08 PM on April 28, 2023: member

Concept ACK
in test/functional/test_framework/util.py:1 in 75b8ba524d
maflcko commented at 12:10 PM on April 28, 2023:

test/functional/test_framework/util.py:18:1: F401 'unittest' imported but unused
fjahr commented at 12:57 PM on April 28, 2023:

Thanks, fixed.
DrahtBot added the label CI failed on Apr 28, 2023
test: remove modinv python util helper function dc14ba08e6
fjahr force-pushed on Apr 28, 2023
kevkevinpal commented at 12:49 PM on April 28, 2023: contributor

Concept ACK also did a grep for modinv in /test and looks like you got all them
DrahtBot removed the label CI failed on Apr 28, 2023
theStack approved
theStack commented at 1:25 PM on April 28, 2023: contributor

ACK dc14ba08e6e502f3e31d935bcd053a287c6610ca
fanquake merged this on May 1, 2023
fanquake closed this on May 1, 2023
sidhujag referenced this in commit 0c991e686c on May 1, 2023
stratospher referenced this in commit a250d70e85 on Jun 9, 2023
stratospher commented at 6:23 PM on June 9, 2023: contributor

we'd need to remove util from TEST_FRAMEWORK_MODULES in test_runner too. i've included this in #24005 where anyways TEST_FRAMEWORK_MODULES has to be touched.
stratospher referenced this in commit eeb44ff4cb on Jun 28, 2023
stratospher referenced this in commit afd762afa3 on Jun 29, 2023
stratospher referenced this in commit a31287718a on Jun 29, 2023
kwvg referenced this in commit 84d6bfd4c8 on Feb 14, 2024
kwvg referenced this in commit d954bd45c6 on Feb 14, 2024
kwvg referenced this in commit 239ec619b1 on Feb 14, 2024
kwvg referenced this in commit e4e1f4178a on Feb 15, 2024
PastaPastaPasta referenced this in commit 3960c1bccf on Feb 19, 2024
PastaPastaPasta referenced this in commit 0f0c53aed3 on Feb 19, 2024
bitcoin locked this on Jun 8, 2024