test: Simplify feature_fastprune.py #27553

1. 
   maflcko commented at 12:18 PM on May 2, 2023: member

   The goal of the test is a single regression check to see if a RPC times out. It shouldn't do more than calling the RPC (and the minimum work needed to get there).

   Fix that by removing all blocktools imports and a for loop.

2. test: Simplify feature_fastprune.py fa17767154
3. 
   DrahtBot commented at 12:18 PM on May 2, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	pinheadmz, theStack

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on May 2, 2023
5. fanquake requested review from theStack on May 2, 2023
6. fanquake requested review from pinheadmz on May 2, 2023
7. fanquake requested review from mzumsande on May 2, 2023
8. pinheadmz approved
9. 
   pinheadmz commented at 2:26 PM on May 2, 2023: member

   ACK fa17767154e21e9ed00782a9e4cf9a3d1d66f5d1

   Thanks for simplifying, dunno why I didn't think of generateblock for this

   <details><summary>Show Signature</summary>

   -----BEGIN PGP SIGNED MESSAGE-----
   Hash: SHA256
   
   ACK fa17767154e21e9ed00782a9e4cf9a3d1d66f5d1
   -----BEGIN PGP SIGNATURE-----
   
   iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAmRRHVcACgkQ5+KYS2KJ
   yTrfcA/+NVtObvE0dL9V50sLrQ6Qep0hJ9MTxdL/nGsa8fL3IOGnH/WV0npEytC3
   FjvAOCbD84CHe2iIvzKkSkT93yDElB9Mz6c35TFbhwHFrRHSGCUK+IFWNuP8aOBb
   kWOZotFF/OYC5JGTGkCX9HC6KuS6dlLrz0IvZb3YQ09D5u8LFfRHOU0Hy/kMK0G6
   1hfdhlGuVvpePdubh67eYH76a0h3jkaIxk1h1nLWgx35+oHXPd5UO3Z+XJP0jP++
   Ch7s6oF7Ae56iNU3hM6fUyMJFP22sEX7c7eMFfyN4uzJ37PS80HddLDUZ9Doq9oR
   lSBIr92G8leeqiCyJrHS1gjvA2+cfbvBrpkeTRoCybB2X0HlPM+Av5vA8C+Ld+En
   enAGONGEF1M9ohawt9iTMkdEO//3V0TjeN6JkqIV/uD6xvrT6CMKuhCZTV1Kl/m4
   AQud3QCXyxE2Qf9zMvC+SW+1zM+g2y+CbhyfQOjc0Maef4unBAaabL3B0kuDed8D
   VlddZbAH/nY+3xSJaiCUevulZI+fdKvsNj0gQzc7/11lCBHRkAik7OGL6r9zA9N0
   LvSOCfpaOfqWkQhcltm1G9uUemNVT9eX6at3bHD3wnGqCnnCcDZPxQf0P1iEIypg
   MZQ9mMnfr9aWA9GVS2hikxKvYVLBsNIVplyLC4NHE808bMoYrZE=
   =u3IH
   -----END PGP SIGNATURE-----
   

   pinheadmz's public key is on keybase

   </details>

10. theStack approved
11. 
    theStack commented at 8:16 PM on May 2, 2023: contributor

    ACK fa17767154e21e9ed00782a9e4cf9a3d1d66f5d1

    Checked that the size of the generated blocks in master and PR are about equal by adding print(len(bytes.fromhex(self.nodes[0].getblock(self.nodes[0].getbestblockhash(), 0)))) at the end of the test (interestingly, in the PR the block is exactly 1 byte larger [65904 vs. 65903] but that doesn't matter of course).

12. fanquake merged this on May 3, 2023
13. fanquake closed this on May 3, 2023

    ---

14. maflcko deleted the branch on May 3, 2023
15. sidhujag referenced this in commit c31f4ec46e on May 4, 2023
16. bitcoin locked this on May 2, 2024

Review Requested
mzumsande