ci: Remove CI_EXEC bloat in test/06_script_b.sh #27573

1. 
   maflcko commented at 4:19 pm on May 4, 2023: member

   CI_EXEC has many issues:

   • It is roughly equivalent to bash -c "$*", meaning that the full command will be treated as a single string, ignoring tokens.
   • It must be put in front of (almost) every command, making it easy to forget, hard to debug the resulting failure, and the code verbose.

   Fix all issues in one script by removing it.

2. 
   DrahtBot commented at 4:19 pm on May 4, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake, TheCharlatan

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #27571 (ci: Run iwyu on all src files by MarcoFalke)
   • #27530 (Remove now-unnecessary poll, fcntl includes from net(base).cpp by Empact)
   • #27425 (test: move remaining rand code from util/setup_common to util/random by jonatack)
   • #27385 (net, refactor: extract Network and BIP155Network logic to node/network by jonatack)
   • #25797 (build: Add CMake-based build system by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot renamed this:
   ci: Remove CI_EXEC bloat in test/06_script_b.sh
   ci: Remove CI_EXEC bloat in test/06_script_b.sh
   on May 4, 2023
4. DrahtBot added the label Tests on May 4, 2023
5. maflcko force-pushed on May 4, 2023
6. DrahtBot added the label CI failed on May 4, 2023
7. maflcko force-pushed on May 4, 2023
8. maflcko force-pushed on May 4, 2023
9. maflcko force-pushed on May 4, 2023
10. maflcko force-pushed on May 4, 2023
11. maflcko force-pushed on May 4, 2023
12. maflcko force-pushed on May 4, 2023
13. maflcko force-pushed on May 4, 2023
14. maflcko force-pushed on May 4, 2023
15. maflcko force-pushed on May 4, 2023
16. maflcko force-pushed on May 4, 2023
17. maflcko force-pushed on May 4, 2023
18. maflcko force-pushed on May 4, 2023
19. maflcko force-pushed on May 4, 2023
20. maflcko force-pushed on May 4, 2023
21. DrahtBot removed the label CI failed on May 4, 2023
22. ci: Pass full env to CI pod to avoid missing a var

    Instead of enumerating each passed env var, just pass all. This avoids
    the risk of missing to enumerate one. Also, it is less code.
    
    The risk could be that an env var causes non-deterministic behavior, but
    this can be fixed by explicitly excluding it once the issue is known.
    
    Values with newlines can not be stored in the file and parsed by
    docker/podman, so they are excluded.

    fa7d75540e
23. ci: Move CI container kill out of 06_script_b.sh

    This cleans up 06_script_b.sh to only contain code to be executed inside
    the CI pod, which avoids confusion and is needed for the next commit.

    fae8de926a
24. ci: Remove CI_EXEC bloat in test/06_script_b.sh fa1dbd04ca
25. maflcko force-pushed on May 5, 2023
26. fanquake approved
27. 
    fanquake commented at 2:38 pm on May 9, 2023: member

    ACK fa1dbd04cab8039440e721eddabb760a40ba8c61 - this conflicts with #27125, but that is going to be rebased soon, and this could be merged in the interim. cc TheCharlatan
28. TheCharlatan approved
29. 
    TheCharlatan commented at 10:39 am on May 10, 2023: contributor

    ACK fa1dbd04cab8039440e721eddabb760a40ba8c61
30. 
    fanquake commented at 10:55 am on May 10, 2023: member

    Merging this now. #27125 is going to be re-rebased to deal with the (minor) conflict. That PR is also waiting on at least one followup comment.
31. fanquake merged this on May 10, 2023
32. fanquake closed this on May 10, 2023

    ---

33. maflcko deleted the branch on May 10, 2023
34. sidhujag referenced this in commit b404e5b812 on May 10, 2023
35. bitcoin locked this on May 9, 2024

Contributors
maflcko DrahtBot fanquake TheCharlatan

Labels
Tests