Small change improves security during the rpcauth directive generation procedure. In this way you can hang the configuration line directly inside the bitcoin.conf file and at the same time show the new password to the user, but without writing it to disk, the new beahvior:
append generated hash in config:
0rpcauth.py user >> bitcoin.conf
show only in stderr without write clear password to disk:
0Your password:
1xxxxx...
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
See the guideline for information on the review process. A summary of reviews will appear here.
From CI:
0102/264 -
1rpc_users.py
2 failed, Duration: 1 s
3stdout:
42023-05-06T19:48:12.787000Z TestFramework (INFO): PRNG seed is: 4992424049312590578
52023-05-06T19:48:12.806000Z TestFramework (INFO): Initializing test directory /tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20230506_193750/rpc_users_159
62023-05-06T19:48:13.197000Z TestFramework (ERROR): Unexpected exception caught during testing
7Traceback (most recent call last):
8 File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 131, in main
9 self.setup()
10 File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 297, in setup
11 self.setup_chain()
12 File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/rpc_users.py", line 65, in setup_chain
13 self.password = lines[3]
14 ~~~~~^^^
15IndexError: list index out of range
From CI:
0102/264 - 1rpc_users.py 2 failed, Duration: 1 s 3stdout: 42023-05-06T19:48:12.787000Z TestFramework (INFO): PRNG seed is: 4992424049312590578 52023-05-06T19:48:12.806000Z TestFramework (INFO): Initializing test directory /tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20230506_193750/rpc_users_159 62023-05-06T19:48:13.197000Z TestFramework (ERROR): Unexpected exception caught during testing 7Traceback (most recent call last): 8 File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 131, in main 9 self.setup() 10 File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 297, in setup 11 self.setup_chain() 12 File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/rpc_users.py", line 65, in setup_chain 13 self.password = lines[3] 14 ~~~~~^^^ 15IndexError: list index out of range
many tnks @brunoerg I found the problem and I am trying run testing in local. Now is passed for me.
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits @MarcoFalke done, the resultant commit, only two files edited: https://github.com/bitcoin/bitcoin/pull/27588/commits/e1046eca9d637dfd29599d156a57a8a3a7440b23
Instead of enumerating each passed env var, just pass all. This avoids
the risk of missing to enumerate one. Also, it is less code.
The risk could be that an env var causes non-deterministic behavior, but
this can be fixed by explicitly excluding it once the issue is known.
Values with newlines can not be stored in the file and parsed by
docker/podman, so they are excluded.
This cleans up 06_script_b.sh to only contain code to be executed inside
the CI pod, which avoids confusion and is needed for the next commit.
This is a follow up of https://github.com/bitcoin/bitcoin/pull/27491,
more concretely
https://github.com/bitcoin/bitcoin/pull/27491#discussion_r1188847896,
for not using default cases (as per the style guide), and
https://github.com/bitcoin/bitcoin/pull/27491#discussion_r1188852707 and
https://github.com/bitcoin/bitcoin/pull/27491#discussion_r1188851857 for
avoiding dead code.
Also change chain name to chain type in docstrings
-BEGIN VERIFY SCRIPT-
sed --regexp-extended -i 's/find_value\(([^ ,]+), /\1.find_value(/g' $(git grep -l find_value)
-END VERIFY SCRIPT-
This can be reverted once gcc excludes lambdas with decltype(auto)
return type from its -Wdangling-reference analysis.
🐙 This pull request conflicts with the target branch and needs rebase.
