This has been superseded by the MockableDatabase. Remove to avoid confusion as to which type of mock database to use for testing.
I thought this was included in #26715, maybe it got lost in a rebase.
walletdb: Remove unused CreateMockWalletDatabase #27665
pull achow101 wants to merge 1 commits into bitcoin:master from achow101:rm-mockdb changing 2 files +0 −38-
achow101 commented at 8:33 PM on May 15, 2023: member
-
0282b2126d
walletdb: Remove unused CreateMockWalletDatabase
This has been superseded by the MockableDatabase. Remove to avoid confusion as to which type of mock database to use for testing.
-
DrahtBot commented at 8:33 PM on May 15, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #27286 (wallet: Keep track of the wallet's own transaction outputs in memory by achow101)
- #24914 (wallet: Load database records in a particular order by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- furszy approved
-
furszy commented at 8:37 PM on May 15, 2023: member
utACK 0282b212
-
- brunoerg approved
-
brunoerg commented at 9:11 PM on May 15, 2023: contributor
crACK 0282b2126dcc1216a25417db0716a3a28489b72d
- fanquake merged this on May 16, 2023
- fanquake closed this on May 16, 2023
- sidhujag referenced this in commit 0536b32890 on May 17, 2023
- bitcoin locked this on May 15, 2024
