build: Bump minimum supported Clang to clang-10

maflcko commented at 8:04 am on May 17, 2023: member

It doesn’t make sense to support a minimum clang version that is difficult to install on all supported operating systems, which generally ship a later version:

Ubuntu Focal 20.04: https://packages.ubuntu.com/focal/clang-10 and https://packages.ubuntu.com/focal/clang-12
Debian Bullseye: https://packages.debian.org/bullseye/clang-13
CentOS 8 Stream: All Clang versions from 11.0 to 15.0

Also, it allows to drop build code, which means it won’t waste review when rolling over into cmake (cmake/module/CheckStdFilesystem.cmake).

doc: Remove outdated CentOS comment

No longer applicable after CONFIG_SHELL must be explicitly set to dash
after commit fafc55a489d8f654dd7732b699c9bf51b5136b4b.

fad7cfee8d

DrahtBot commented at 8:04 am on May 17, 2023: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto, fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#27662 (build: Bump minimum supported GCC to g++-9 by MarcoFalke)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot renamed this:
~~build: Bump minimum Clang to clang-10~~
build: Bump minimum Clang to clang-10
on May 17, 2023

DrahtBot added the label Build system on May 17, 2023

maflcko renamed this:
~~build: Bump minimum Clang to clang-10~~
build: Bump minimum supported Clang to clang-10
on May 17, 2023

hebasto commented at 8:10 am on May 17, 2023: member

Also, it allows to drop build code, which means it won’t waste review when rolling over into cmake (cmake/module/CheckStdFilesystem.cmake).

Concept ACK.

maflcko force-pushed on May 17, 2023

in build-aux/m4/l_filesystem.m4:37 in fa5ab98d57 outdated

29@@ -31,15 +30,8 @@ AC_DEFUN([CHECK_FILESYSTEM], [
30       AC_MSG_CHECKING([whether std::filesystem needs -lstdc++fs])
31       AC_LINK_IFELSE([AC_LANG_SOURCE([_CHECK_FILESYSTEM_testbody])],[
32           AC_MSG_RESULT([yes])
33-        ],[
34-          AC_MSG_RESULT([no])
35-          AC_MSG_CHECKING([whether std::filesystem needs -lc++fs])
36-          LIBS="$SAVED_LIBS -lc++fs"

hebasto commented at 8:18 am on May 17, 2023:

The only left usage of SAVED_LIBS can de dropped as well:

 0--- a/build-aux/m4/l_filesystem.m4
 1+++ b/build-aux/m4/l_filesystem.m4
 2@@ -25,8 +25,7 @@ AC_DEFUN([CHECK_FILESYSTEM], [
 3       AC_MSG_RESULT([yes])
 4     ],[
 5       AC_MSG_RESULT([no])
 6-      SAVED_LIBS="$LIBS"
 7-      LIBS="$SAVED_LIBS -lstdc++fs"
 8+      LIBS="$LIBS -lstdc++fs"
 9       AC_MSG_CHECKING([whether std::filesystem needs -lstdc++fs])
10       AC_LINK_IFELSE([AC_LANG_SOURCE([_CHECK_FILESYSTEM_testbody])],[
11           AC_MSG_RESULT([yes])

maflcko commented at 8:24 am on May 17, 2023:

Ok, will do on the next push. Otherwise it will go away when the file is translated to cmake or when GCC is bumped to g++-9, whichever happens earlier.

maflcko commented at 8:56 am on May 17, 2023:

Thanks, done.

hebasto commented at 8:26 am on May 17, 2023: member

Just noting that our current Guix environment uses Clang 10.0.1.

build: Bump minimum Clang to clang-10 fad2c200f4

ci: Drop NO_WERROR=1 for clang-10 build

This partially reverts commit 71383f2fad065378393ef55b6d65e14c656b7301.
This should be fine, because if warnings are issues again in the future,
it can be disabled again, along with a list of the false warnings.

fa199ee614

maflcko force-pushed on May 17, 2023

DrahtBot added the label CI failed on May 17, 2023

hebasto approved

hebasto commented at 9:16 am on May 17, 2023: member

ACK fa199ee614a7ed99c6caf329093a3573ea5a664b

maflcko added the label DrahtBot Guix build requested on May 17, 2023

hebasto commented at 9:50 am on May 17, 2023: member

Guix builds:

04837adede6c57a98c0bc0ddaa178870a543c3f6ce9c3c8cd47841262937637c7  guix-build-fa199ee614a7/output/arm64-apple-darwin/SHA256SUMS.part
17ff35a219b09300f27a03b00196367ae9f17effab610e440a60322b0dd6a22e8  guix-build-fa199ee614a7/output/arm64-apple-darwin/bitcoin-fa199ee614a7-arm64-apple-darwin-unsigned.dmg
24dcf0408d81b0558f30055749334b966b8b1d2269da32238ff1f219e3e027bfc  guix-build-fa199ee614a7/output/arm64-apple-darwin/bitcoin-fa199ee614a7-arm64-apple-darwin-unsigned.tar.gz
3169fea2e7e671692b611e555e00f1c282efb862b3abc080df50897251f188a8b  guix-build-fa199ee614a7/output/arm64-apple-darwin/bitcoin-fa199ee614a7-arm64-apple-darwin.tar.gz
456ce8a8945ab2b1f1cebec4c07eb2cd62e8292b97d8240ed15dded1490e196fd  guix-build-fa199ee614a7/output/dist-archive/bitcoin-fa199ee614a7.tar.gz
56765669d7170f6490b644fc278dd2ff92fd19d6dba21d7e68cf68c6a5ce3f13c  guix-build-fa199ee614a7/output/x86_64-apple-darwin/SHA256SUMS.part
6fffe1dbf1736d23fe03c5fe1351ead10be1ed509871779bd185c655e87d17225  guix-build-fa199ee614a7/output/x86_64-apple-darwin/bitcoin-fa199ee614a7-x86_64-apple-darwin-unsigned.dmg
70f20ad10bbfc1c68e352682f7ae9ba8105a7f27c72f066158fd63a085c007541  guix-build-fa199ee614a7/output/x86_64-apple-darwin/bitcoin-fa199ee614a7-x86_64-apple-darwin-unsigned.tar.gz
820b4e3fd43b878722f390ebd394fcee6a320630c9d73d67565231ba6536e55aa  guix-build-fa199ee614a7/output/x86_64-apple-darwin/bitcoin-fa199ee614a7-x86_64-apple-darwin.tar.gz

DrahtBot removed the label CI failed on May 17, 2023

maflcko commented at 12:55 pm on May 17, 2023: member

For completeness, building with clang-9 is likely still possible, it is just not supported and checked by the CI.

fanquake commented at 1:11 pm on May 17, 2023: member

Guix Build:

 087a9f57e4436db8aa1f892cd7a5bfacaade632d518cf99f3f036ea59936b01a6  guix-build-fa199ee614a7/output/aarch64-linux-gnu/SHA256SUMS.part
 17f2cb983eb4433db2e7e8acaa014069b978e999330a2850846ecff66e5276c30  guix-build-fa199ee614a7/output/aarch64-linux-gnu/bitcoin-fa199ee614a7-aarch64-linux-gnu-debug.tar.gz
 2ba5144a64d5f70adf26b072c966925c79a56d4501389478d2a240daacd523a96  guix-build-fa199ee614a7/output/aarch64-linux-gnu/bitcoin-fa199ee614a7-aarch64-linux-gnu.tar.gz
 300d8f4b7904f6e712c2a319ef77ab33770703347d7b8901d28ef644fead73887  guix-build-fa199ee614a7/output/arm-linux-gnueabihf/SHA256SUMS.part
 425ebac3e9418c6d742e444695342b7d68ca6fd01558a38d4d7812c6fe52a0bbd  guix-build-fa199ee614a7/output/arm-linux-gnueabihf/bitcoin-fa199ee614a7-arm-linux-gnueabihf-debug.tar.gz
 524443acc11a13958566e7d272b98d00c9894364005462e40b2d6e95908ab8b0b  guix-build-fa199ee614a7/output/arm-linux-gnueabihf/bitcoin-fa199ee614a7-arm-linux-gnueabihf.tar.gz
 64837adede6c57a98c0bc0ddaa178870a543c3f6ce9c3c8cd47841262937637c7  guix-build-fa199ee614a7/output/arm64-apple-darwin/SHA256SUMS.part
 77ff35a219b09300f27a03b00196367ae9f17effab610e440a60322b0dd6a22e8  guix-build-fa199ee614a7/output/arm64-apple-darwin/bitcoin-fa199ee614a7-arm64-apple-darwin-unsigned.dmg
 84dcf0408d81b0558f30055749334b966b8b1d2269da32238ff1f219e3e027bfc  guix-build-fa199ee614a7/output/arm64-apple-darwin/bitcoin-fa199ee614a7-arm64-apple-darwin-unsigned.tar.gz
 9169fea2e7e671692b611e555e00f1c282efb862b3abc080df50897251f188a8b  guix-build-fa199ee614a7/output/arm64-apple-darwin/bitcoin-fa199ee614a7-arm64-apple-darwin.tar.gz
1056ce8a8945ab2b1f1cebec4c07eb2cd62e8292b97d8240ed15dded1490e196fd  guix-build-fa199ee614a7/output/dist-archive/bitcoin-fa199ee614a7.tar.gz
11d1c1452c9fd368a9f1b974b9539e468b16ebe8cf2e5d3a58c8f704092ff365b7  guix-build-fa199ee614a7/output/powerpc64-linux-gnu/SHA256SUMS.part
1206aecc75730870954fd5e12454f86c1e70eb7456fca7472e2cf80eefc11c4c01  guix-build-fa199ee614a7/output/powerpc64-linux-gnu/bitcoin-fa199ee614a7-powerpc64-linux-gnu-debug.tar.gz
13724d581d4f27912bbcb0d61837f822292ec53e4cea1978243bd08e54a33f577c  guix-build-fa199ee614a7/output/powerpc64-linux-gnu/bitcoin-fa199ee614a7-powerpc64-linux-gnu.tar.gz
14f399d55f7e158432530d6c89e39d40db1e937ef823c3dcb36ef77e9a62534f76  guix-build-fa199ee614a7/output/powerpc64le-linux-gnu/SHA256SUMS.part
156fd9fac36a2c7cb88ef1fd40cd3d3961e1de97f18142244216a3092928fd29a6  guix-build-fa199ee614a7/output/powerpc64le-linux-gnu/bitcoin-fa199ee614a7-powerpc64le-linux-gnu-debug.tar.gz
166a89449b213935baf61fc02ba56f74ad9748ab945d9cd8d6cf3a507869c0532d  guix-build-fa199ee614a7/output/powerpc64le-linux-gnu/bitcoin-fa199ee614a7-powerpc64le-linux-gnu.tar.gz
17a735905eff1b310bbd12ec4348d609f56d86ce92cef23e5bc67f97517dba7e43  guix-build-fa199ee614a7/output/riscv64-linux-gnu/SHA256SUMS.part
18242740d4222b8808c379d38cb657011b696e0c71690e16880a23418df4458192  guix-build-fa199ee614a7/output/riscv64-linux-gnu/bitcoin-fa199ee614a7-riscv64-linux-gnu-debug.tar.gz
19fd44487f5f1d5d08c61eeba727c75b21397dc90f96ac883933a2dfa2a96fa271  guix-build-fa199ee614a7/output/riscv64-linux-gnu/bitcoin-fa199ee614a7-riscv64-linux-gnu.tar.gz
206765669d7170f6490b644fc278dd2ff92fd19d6dba21d7e68cf68c6a5ce3f13c  guix-build-fa199ee614a7/output/x86_64-apple-darwin/SHA256SUMS.part
21fffe1dbf1736d23fe03c5fe1351ead10be1ed509871779bd185c655e87d17225  guix-build-fa199ee614a7/output/x86_64-apple-darwin/bitcoin-fa199ee614a7-x86_64-apple-darwin-unsigned.dmg
220f20ad10bbfc1c68e352682f7ae9ba8105a7f27c72f066158fd63a085c007541  guix-build-fa199ee614a7/output/x86_64-apple-darwin/bitcoin-fa199ee614a7-x86_64-apple-darwin-unsigned.tar.gz
2320b4e3fd43b878722f390ebd394fcee6a320630c9d73d67565231ba6536e55aa  guix-build-fa199ee614a7/output/x86_64-apple-darwin/bitcoin-fa199ee614a7-x86_64-apple-darwin.tar.gz
24ffa43154cc7a04a1de47b7dd048b3a0f81bf4b80d6aec9cf0c34a2fbace1ba41  guix-build-fa199ee614a7/output/x86_64-linux-gnu/SHA256SUMS.part
250c022395d14342c5c47af6159d012ec893a563507ff982b027f5795a618c7b1e  guix-build-fa199ee614a7/output/x86_64-linux-gnu/bitcoin-fa199ee614a7-x86_64-linux-gnu-debug.tar.gz
26d53c0a1892365a76138a4b4de2669ab45aa7a39cabc9f7948f97f9c9c375e09d  guix-build-fa199ee614a7/output/x86_64-linux-gnu/bitcoin-fa199ee614a7-x86_64-linux-gnu.tar.gz
27295f21754d327d02de041e3c40ccc489b7eb9e3082169707c6877d083224f773  guix-build-fa199ee614a7/output/x86_64-w64-mingw32/SHA256SUMS.part
28c05dd128aca5e2845670ce412432704a44bf4fb61023df3d8d9079c7c91a9eab  guix-build-fa199ee614a7/output/x86_64-w64-mingw32/bitcoin-fa199ee614a7-win64-debug.zip
296bffc1901af5ae0623c586392d221be62a177cbddcf6adca4f4f73a44581ee16  guix-build-fa199ee614a7/output/x86_64-w64-mingw32/bitcoin-fa199ee614a7-win64-setup-unsigned.exe
3058623eb17277782e952defb013a0ae7090b2db6c00b6d43d37d4c6d3fae53fe9  guix-build-fa199ee614a7/output/x86_64-w64-mingw32/bitcoin-fa199ee614a7-win64-unsigned.tar.gz
31d7e8f973e9a6282c59545e1f52d92c758da57e16d1ef531d43754bc99932f671  guix-build-fa199ee614a7/output/x86_64-w64-mingw32/bitcoin-fa199ee614a7-win64.zip

fanquake approved

fanquake commented at 1:21 pm on May 17, 2023: member

ACK fa199ee614a7ed99c6caf329093a3573ea5a664b

DrahtBot commented at 7:01 pm on May 17, 2023: contributor

Guix builds

File	commit a75c77ea903c100531e0fc5fde94bb9b52642145(master)	commit 17e23f9f640731303585bb919919611200eb86a3(master and this pull)
SHA256SUMS.part	`434bbf6e6617a5de...`	`15dc0d0d8858f1b1...`
*-aarch64-linux-gnu-debug.tar.gz	`0e712bb15da16909...`	`e350ef92e0f04f2b...`
*-aarch64-linux-gnu.tar.gz	`ae2f0f4a424693d6...`	`95fe37b4dcd6d3a5...`
*-arm-linux-gnueabihf-debug.tar.gz	`cd532071bf713066...`	`89e076b67137a35d...`
*-arm-linux-gnueabihf.tar.gz	`4c1728e9d71867ce...`	`1d23f4c275504e91...`
*-powerpc64-linux-gnu-debug.tar.gz	`f9b571a4968316f6...`	`52f9d53e6efa12ef...`
*-powerpc64-linux-gnu.tar.gz	`55fdbbad89963dad...`	`54d033e1fd770808...`
*-powerpc64le-linux-gnu-debug.tar.gz	`f38d53401f133237...`	`6bd928a6e626980d...`
*-powerpc64le-linux-gnu.tar.gz	`0b36ad26323ff653...`	`0535d18601755c54...`
*-riscv64-linux-gnu-debug.tar.gz	`3eda34ba2def1068...`	`5228cef95943bd2a...`
*-riscv64-linux-gnu.tar.gz	`0eb983ca2a074b4b...`	`a83f9c52dcf8fb3d...`
*-x86_64-linux-gnu-debug.tar.gz	`db4fe4e006203a8f...`	`371c572e1bcd0573...`
*-x86_64-linux-gnu.tar.gz	`53535f16dac817fe...`	`cfacf93467a10044...`
*.tar.gz	`54187f92f6847350...`	`91173ae7fb5ace03...`
guix_build.log	`33cd49590ace6813...`	`2273117902ab8298...`
guix_build.log.diff		`fd8b8dbd0321f286...`

DrahtBot removed the label DrahtBot Guix build requested on May 17, 2023

fanquake merged this on May 18, 2023

fanquake closed this on May 18, 2023

maflcko deleted the branch on May 18, 2023

sidhujag referenced this in commit 3600c047c7 on May 19, 2023

bitcoin locked this on May 17, 2024

build: Bump minimum supported Clang to clang-10 #27682

Reviews

Conflicts

Guix builds