ci: remove RUN_SECURITY_TESTS #27683

1. 
   fanquake commented at 9:58 am on May 17, 2023: member

   We no-longer run any security/symbol checks in the CI, and doubt we will in future (if we do, it’ll be via Guix, where this var would be redundant in any case). The CI environment doesn’t (exactly) match the release build environment (and is semi-regularly changing), and the binaries produced in the CI don’t match how we build release binaries, so there is no point trying to run these checks, especially as we add more involved tests, i.e #26953.
2. ci: remove RUN_SECURITY_TESTS

   We no-longer run any security/syymbol checks in the CI, and doubt we
   will in future (if we do, it'll be via Guix, where this var would be
   redundant in any case). The CI environment doesn't (exactly) match the
   release build environment (and is semi-regularly changing), and the
   binaries produced in the CI don't match how we build release binaries,
   so there is no point trying to run these checks, especially as we add
   more involved tests, i.e #26953.

   6a936580d1
3. 
   DrahtBot commented at 9:58 am on May 17, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	josibake, TheCharlatan
   Concept ACK	hebasto

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on May 17, 2023
5. 
   hebasto commented at 10:21 am on May 17, 2023: member

   We no-longer run any security/symbol checks in the CI, and doubt we will in future (if we do, it’ll be via Guix, where this var would be redundant in any case).

   Concept ACK on that.

6. fanquake requested review from josibake on May 20, 2023
7. 
   josibake commented at 11:04 am on May 20, 2023: member

   code review ACK https://github.com/bitcoin/bitcoin/pull/27683/commits/6a936580d1c42576f627d5fac5423ec7af88e547

   +1 on removing “off by default” stuff from the CI scripts. also agree that guix is the right place to be handling these sorts of checks

8. DrahtBot removed review request from josibake on May 20, 2023
9. TheCharlatan approved
10. 
    TheCharlatan commented at 8:08 pm on May 20, 2023: contributor

    ACK 6a936580d1c42576f627d5fac5423ec7af88e547

    Doesn’t make sense to maintain this.

11. fanquake merged this on May 22, 2023
12. fanquake closed this on May 22, 2023

    ---

13. fanquake deleted the branch on May 22, 2023
14. sidhujag referenced this in commit 93833d3884 on May 23, 2023
15. bitcoin locked this on May 21, 2024

Contributors
fanquake DrahtBot hebasto josibake TheCharlatan

Labels
Tests