This breaks the mempool, causes an assert(false) in -debug mode and can cause SEGFAULT in non-debug mode
Remove broken option to skip input checking for wallet txn. #2769
pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:master changing 5 files +15 −16-
TheBlueMatt commented at 10:24 AM on June 14, 2013: member
-
Remove broken option to skip input checking for wallet txn. b1f15b218b
-
sipa commented at 10:27 AM on June 14, 2013: member
ACK
-
BitcoinPullTester commented at 12:07 PM on June 14, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/b1f15b218be8dfd1d2dbd375d469794bb7326748 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
jgarzik commented at 1:50 PM on June 14, 2013: contributor
ACK
-
petertodd commented at 5:37 PM on June 14, 2013: contributor
ACK
In my mempool rewrite work I also implemented this change and haven't found any downside to doing so. The wallet code is perfectly ok if there are tx's in the wallet that don't make it to the mempool for whatever reason.
- sipa referenced this in commit 9e3a5deaa3 on Jun 15, 2013
- sipa merged this on Jun 15, 2013
- sipa closed this on Jun 15, 2013
-
petertodd commented at 10:19 AM on July 4, 2013: contributor
Actually you broke transaction resurrection in the event of a multi-block re-org with this patch because transactions get added back to the mempool in the wrong order, the correct order within a block, but newest block first. See SetBestChain() for details.
- DrahtBot locked this on Sep 8, 2021
